[Qemu-trivial] [PATCH] bsd-user: fix compile failure

[Qemu-trivial] [PATCH] bsd-user: fix compile failure

[Peter Maydell]

bsd-user doesn't actually support reserving a memory area for the
guest address space, but we need to at least define the reserved_va
global so that cpu-all.h's RESERVED_VA macro will work correctly.

This fixes a compilation error introduced in commit
which added a use of RESERVED_VA to h2g_valid().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 bsd-user/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bsd-user/main.c b/bsd-user/main.c
index 48cb715..0689e38 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -41,6 +41,7 @@ int singlestep;
 unsigned long mmap_min_addr;
 unsigned long guest_base;
 int have_guest_base;
+unsigned long reserved_va;
 #endif
 
 static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
-- 
1.7.1

Re: [Qemu-trivial] [Qemu-devel] [PATCH] bsd-user: fix compile failure

[Andreas Färber]

Am 12.04.2012 12:22, schrieb Peter Maydell:
> bsd-user doesn't actually support reserving a memory area for the
> guest address space, but we need to at least define the reserved_va
> global so that cpu-all.h's RESERVED_VA macro will work correctly.
> 
> This fixes a compilation error introduced in commit

Did you forget to paste the commit hash here? Otherwise a "the" seems
missing.

> which added a use of RESERVED_VA to h2g_valid().
> 

Reported-by: Brad Smith <brad@comstyle.com>

from what I remember.

> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  bsd-user/main.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 48cb715..0689e38 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -41,6 +41,7 @@ int singlestep;
>  unsigned long mmap_min_addr;
>  unsigned long guest_base;
>  int have_guest_base;
> +unsigned long reserved_va;
>  #endif
>  
>  static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;

Looks okay to me but don't have BSD setup to test.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg