[Qemu-trivial] [PATCH 1/2] async: Use bool for boolean struct members and remove a hole

[Qemu-trivial] [PATCH 1/2] async: Use bool for boolean struct members and remove a hole

[Stefan Weil]

Using bool reduces the size of the structure and improves readability.
A hole in the structure was removed.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 async.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/async.c b/async.c
index ecdaf15..85cc641 100644
--- a/async.c
+++ b/async.c
@@ -35,10 +35,10 @@ static struct QEMUBH *first_bh;
 struct QEMUBH {
     QEMUBHFunc *cb;
     void *opaque;
-    int scheduled;
-    int idle;
-    int deleted;
     QEMUBH *next;
+    bool scheduled;
+    bool idle;
+    bool deleted;
 };
 
 QEMUBH *qemu_bh_new(QEMUBHFunc *cb, void *opaque)
-- 
1.7.9

[Qemu-trivial] [PATCH 2/2] iohandler: Use bool for boolean struct member and remove holes

[Stefan Weil]

Using bool reduces the size of the structure and improves readability.
Two holes in the structure were removed.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 iohandler.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/iohandler.c b/iohandler.c
index 5640d49..3c74de6 100644
--- a/iohandler.c
+++ b/iohandler.c
@@ -33,13 +33,13 @@
 #endif
 
 typedef struct IOHandlerRecord {
-    int fd;
     IOCanReadHandler *fd_read_poll;
     IOHandler *fd_read;
     IOHandler *fd_write;
-    int deleted;
     void *opaque;
     QLIST_ENTRY(IOHandlerRecord) next;
+    int fd;
+    bool deleted;
 } IOHandlerRecord;
 
 static QLIST_HEAD(, IOHandlerRecord) io_handlers =
-- 
1.7.9

Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] async: Use bool for boolean struct members and remove a hole

[Stefan Hajnoczi]

On Sun, Apr 29, 2012 at 07:08:45PM +0200, Stefan Weil wrote:
> Using bool reduces the size of the structure and improves readability.
> A hole in the structure was removed.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  async.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks, applied both to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan