From: Alberto Garcia <agarcia@igalia.com>
To: qemu-trivial@nongnu.org
Cc: Orit Wasserman <owasserm@redhat.com>
Subject: [Qemu-trivial] [PATCH] savevm: fix compiler warning
Date: Tue, 14 Aug 2012 23:18:32 +0300 [thread overview]
Message-ID: <1344975512-15542-1-git-send-email-agarcia@igalia.com> (raw)
If we have a 32-bit long then the truncation of a 64-bit value will
produce a compiler warning unless we make an explicit cast.
---
savevm.c | 2 +-
1 ficheiro modificado, 1 adição(+), 1 eliminado(-)
diff --git a/savevm.c b/savevm.c
index 0ea10c9..c89fc4e 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2473,7 +2473,7 @@ int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen,
/* word at a time for speed, use of 32-bit long okay */
if (!res) {
/* truncation to 32-bit long okay */
- long mask = 0x0101010101010101ULL;
+ long mask = (long) 0x0101010101010101ULL;
while (i < slen) {
xor = *(long *)(old_buf + i) ^ *(long *)(new_buf + i);
if ((xor - mask) & ~xor & (mask << 7)) {
--
1.7.10.4
next reply other threads:[~2012-08-14 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 20:18 Alberto Garcia [this message]
2012-08-15 13:30 ` [Qemu-trivial] [PATCH] savevm: fix compiler warning Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344975512-15542-1-git-send-email-agarcia@igalia.com \
--to=agarcia@igalia.com \
--cc=owasserm@redhat.com \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).