* [Qemu-trivial] [PATCH v2] block/curl.c: Refuse to open the handle for writes.
@ 2013-06-10 11:38 Richard W.M. Jones
2013-06-10 11:38 ` Richard W.M. Jones
0 siblings, 1 reply; 3+ messages in thread
From: Richard W.M. Jones @ 2013-06-10 11:38 UTC (permalink / raw)
To: qemu-trivial; +Cc: kwolf, qemu-devel, stefanha
v2:
- Use qerror_report to report an error.
- Return -EROFS instead of -ENOTSUP.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-trivial] [PATCH v2] block/curl.c: Refuse to open the handle for writes.
2013-06-10 11:38 [Qemu-trivial] [PATCH v2] block/curl.c: Refuse to open the handle for writes Richard W.M. Jones
@ 2013-06-10 11:38 ` Richard W.M. Jones
2013-06-10 11:56 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Richard W.M. Jones @ 2013-06-10 11:38 UTC (permalink / raw)
To: qemu-trivial; +Cc: kwolf, qemu-devel, stefanha
From: "Richard W.M. Jones" <rjones@redhat.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/curl.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index b8935fd..b634ccf 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -406,6 +406,12 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags)
static int inited = 0;
+ if (flags & BDRV_O_RDWR) {
+ qerror_report(ERROR_CLASS_GENERIC_ERROR,
+ "curl block device does not support writes");
+ return -EROFS;
+ }
+
opts = qemu_opts_create_nofail(&runtime_opts);
qemu_opts_absorb_qdict(opts, options, &local_err);
if (error_is_set(&local_err)) {
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 11:38 [Qemu-trivial] [PATCH v2] block/curl.c: Refuse to open the handle for writes Richard W.M. Jones
2013-06-10 11:38 ` Richard W.M. Jones
2013-06-10 11:56 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).