From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-trivial] [PATCH] qmp: Report path ambiguity error.
Date: Mon, 28 Apr 2014 23:46:26 +0100 [thread overview]
Message-ID: <1398725186-8202-1-git-send-email-kroosec@gmail.com> (raw)
Signed-off-by: Hani Benhabiles <hani@linux.com>
Suggested-by: Andreas Färber <afaerber@suse.de>
---
qmp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/qmp.c b/qmp.c
index 74107be..0d49abf 100644
--- a/qmp.c
+++ b/qmp.c
@@ -199,7 +199,10 @@ ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
ObjectProperty *prop;
obj = object_resolve_path(path, &ambiguous);
- if (obj == NULL) {
+ if (ambiguous) {
+ error_setg(errp, "Path '%s' is ambiguous", path);
+ return NULL;
+ } else if (obj == NULL) {
error_set(errp, QERR_DEVICE_NOT_FOUND, path);
return NULL;
}
--
1.8.3.2
next reply other threads:[~2014-04-28 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 22:46 Hani Benhabiles [this message]
2014-05-03 8:38 ` [Qemu-trivial] [PATCH] qmp: Report path ambiguity error Michael Tokarev
2014-05-05 9:12 ` Michael Tokarev
2014-05-05 9:26 ` Andreas Färber
2014-05-05 9:31 ` Michael Tokarev
2014-05-05 9:37 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398725186-8202-1-git-send-email-kroosec@gmail.com \
--to=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).