qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable
Date: Mon, 19 May 2014 08:19:25 +0200	[thread overview]
Message-ID: <1400480365.32155.21.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1400336958-32463-1-git-send-email-sw@weilnetz.de>

  Hi,

> +if test "$gtkabi" = ""; then
> +    # The GTK ABI was not specified explicitly, so try whether 2.0 is available.
> +    # Use 3.0 as a fallback if that is available.
> +    if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then
> +        gtkabi=2.0
> +    elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
> +        gtkabi=3.0
> +    else
> +        gtkabi=2.0
> +    fi
> +fi

Shouldn't we probe for gtk3 first?

cheers,
  Gerd




  reply	other threads:[~2014-05-19  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17 14:29 [Qemu-trivial] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable Stefan Weil
2014-05-19  6:19 ` Gerd Hoffmann [this message]
2014-05-19  7:38   ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2014-05-19  7:57     ` Gerd Hoffmann
2014-05-19  7:49 ` [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400480365.32155.21.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).