From: Wei Huang <wei@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
shannon.zhao@linaro.org, zhaoshenglong@huawei.com
Subject: [Qemu-trivial] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse
Date: Thu, 28 Jan 2016 13:22:20 -0500 [thread overview]
Message-ID: <1454005340-15682-1-git-send-email-wei@redhat.com> (raw)
When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot
request will succeed; but the following shutdown/reboot requests
fail to trigger VMs to react. Notice that in mach-virt machine
model GPIO is defined as edge-triggered and active-high in ACPI.
This patch changes the behavior of powerdown notifier from PULLUP
to PULSE. It solves the problem described above (i.e. reboot
continues to work).
Signed-off-by: Wei Huang <wei@redhat.com>
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 05f9087..b5468a9 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -546,7 +546,7 @@ static DeviceState *pl061_dev;
static void virt_powerdown_req(Notifier *n, void *opaque)
{
/* use gpio Pin 3 for power button event */
- qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 1);
+ qemu_irq_pulse(qdev_get_gpio_in(pl061_dev, 3));
}
static Notifier virt_system_powerdown_notifier = {
--
1.8.3.1
next reply other threads:[~2016-01-28 18:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 18:22 Wei Huang [this message]
2016-01-29 10:10 ` [Qemu-trivial] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse Shannon Zhao
2016-01-29 14:35 ` Wei Huang
2016-01-29 14:46 ` Shannon Zhao
2016-01-29 14:50 ` Wei Huang
2016-01-29 15:22 ` Shannon Zhao
2016-01-29 14:50 ` Peter Maydell
2016-01-29 15:13 ` Wei Huang
2016-01-29 15:29 ` Peter Maydell
2016-02-01 10:17 ` [Qemu-trivial] [Qemu-devel] " Igor Mammedov
2016-02-01 17:24 ` Wei Huang
2016-01-30 8:18 ` [Qemu-trivial] " Shannon Zhao
2016-02-03 7:15 ` Michael Tokarev
2016-02-03 10:46 ` Peter Maydell
2016-02-03 16:01 ` Wei Huang
2016-02-04 1:44 ` Shannon Zhao
2016-02-04 6:10 ` Wei Huang
2016-02-04 6:51 ` Shannon Zhao
2016-02-09 22:59 ` Wei Huang
2016-02-20 10:53 ` Shannon Zhao
2016-02-24 22:22 ` Wei Huang
2016-02-26 12:31 ` Shannon Zhao
2016-02-26 12:53 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2016-02-26 14:54 ` Shannon Zhao
2016-02-26 15:06 ` Peter Maydell
2016-02-26 15:28 ` Wei Huang
2016-02-26 15:42 ` Peter Maydell
2016-02-27 1:55 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454005340-15682-1-git-send-email-wei@redhat.com \
--to=wei@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).