From: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
To: <qemu-devel@nongnu.org>
Cc: <qemu-trivial@nongnu.org>, <peter.maydell@linaro.org>,
<xiecl.fnst@cn.fujitsu.com>,
Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: [Qemu-trivial] [Qemu-devel][PATCH v2] accel: make configure_accelerator return void
Date: Thu, 14 Apr 2016 11:58:02 +0800 [thread overview]
Message-ID: <1460606282-4570-1-git-send-email-weijg.fnst@cn.fujitsu.com> (raw)
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
accel.c | 4 +---
include/sysemu/accel.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/accel.c b/accel.c
index 0510b90..403eb5e 100644
--- a/accel.c
+++ b/accel.c
@@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
return ret;
}
-int configure_accelerator(MachineState *ms)
+void configure_accelerator(MachineState *ms)
{
const char *p;
char buf[10];
@@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
if (init_failed) {
fprintf(stderr, "Back to %s accelerator.\n", acc->name);
}
-
- return !accel_initialised;
}
diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
index 997720f..c230f1b 100644
--- a/include/sysemu/accel.h
+++ b/include/sysemu/accel.h
@@ -57,6 +57,6 @@ typedef struct AccelClass {
extern int tcg_tb_size;
-int configure_accelerator(MachineState *ms);
+void configure_accelerator(MachineState *ms);
#endif
--
1.9.3
next reply other threads:[~2016-04-14 3:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 3:58 Wei Jiangang [this message]
2016-05-06 18:52 ` [Qemu-trivial] [PATCH v2] accel: make configure_accelerator return void Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460606282-4570-1-git-send-email-weijg.fnst@cn.fujitsu.com \
--to=weijg.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).