* [Qemu-trivial] [Qemu-devel][PATCH v2] accel: make configure_accelerator return void
@ 2016-04-14 3:58 Wei Jiangang
2016-05-06 18:52 ` [Qemu-trivial] [PATCH " Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Wei Jiangang @ 2016-04-14 3:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell, xiecl.fnst, Wei Jiangang
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
accel.c | 4 +---
include/sysemu/accel.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/accel.c b/accel.c
index 0510b90..403eb5e 100644
--- a/accel.c
+++ b/accel.c
@@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
return ret;
}
-int configure_accelerator(MachineState *ms)
+void configure_accelerator(MachineState *ms)
{
const char *p;
char buf[10];
@@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
if (init_failed) {
fprintf(stderr, "Back to %s accelerator.\n", acc->name);
}
-
- return !accel_initialised;
}
diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
index 997720f..c230f1b 100644
--- a/include/sysemu/accel.h
+++ b/include/sysemu/accel.h
@@ -57,6 +57,6 @@ typedef struct AccelClass {
extern int tcg_tb_size;
-int configure_accelerator(MachineState *ms);
+void configure_accelerator(MachineState *ms);
#endif
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [PATCH v2] accel: make configure_accelerator return void
2016-04-14 3:58 [Qemu-trivial] [Qemu-devel][PATCH v2] accel: make configure_accelerator return void Wei Jiangang
@ 2016-05-06 18:52 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2016-05-06 18:52 UTC (permalink / raw)
To: Wei Jiangang, qemu-devel; +Cc: qemu-trivial, peter.maydell, xiecl.fnst
14.04.2016 06:58, Wei Jiangang wrote:
> Return the negated value of accel_initialised is meaningless,
> and the caller vl doesn't check it.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-06 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-14 3:58 [Qemu-trivial] [Qemu-devel][PATCH v2] accel: make configure_accelerator return void Wei Jiangang
2016-05-06 18:52 ` [Qemu-trivial] [PATCH " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).