* [Qemu-trivial] [PATCH] hw/arm/nseries: Allocating Large sized arrays to heap
@ 2016-04-26 6:15 Zhou Jie
2016-05-04 15:22 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Zhou Jie @ 2016-04-26 6:15 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, balrogg, Zhou Jie
n8x0_init has a huge stack usage of 65536 bytes approx.
Moving large arrays to heap to reduce stack usage.
Signed-off-by: Zhou Jie <zhoujie2011@cn.fujitsu.com>
---
hw/arm/nseries.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 5382505..c7068c0 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -1364,7 +1364,7 @@ static void n8x0_init(MachineState *machine,
if (option_rom[0].name &&
(machine->boot_order[0] == 'n' || !machine->kernel_filename)) {
- uint8_t nolo_tags[0x10000];
+ uint8_t *nolo_tags = g_new(uint8_t, 0x10000);
/* No, wait, better start at the ROM. */
s->mpu->cpu->env.regs[15] = OMAP2_Q2_BASE + 0x400000;
@@ -1383,6 +1383,7 @@ static void n8x0_init(MachineState *machine,
n800_setup_nolo_tags(nolo_tags);
cpu_physical_memory_write(OMAP2_SRAM_BASE, nolo_tags, 0x10000);
+ g_free(nolo_tags);
}
}
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/arm/nseries: Allocating Large sized arrays to heap
2016-04-26 6:15 [Qemu-trivial] [PATCH] hw/arm/nseries: Allocating Large sized arrays to heap Zhou Jie
@ 2016-05-04 15:22 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2016-05-04 15:22 UTC (permalink / raw)
To: Zhou Jie; +Cc: QEMU Developers, QEMU Trivial
On 26 April 2016 at 07:15, Zhou Jie <zhoujie2011@cn.fujitsu.com> wrote:
> n8x0_init has a huge stack usage of 65536 bytes approx.
> Moving large arrays to heap to reduce stack usage.
>
> Signed-off-by: Zhou Jie <zhoujie2011@cn.fujitsu.com>
> ---
> hw/arm/nseries.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 5382505..c7068c0 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -1364,7 +1364,7 @@ static void n8x0_init(MachineState *machine,
>
> if (option_rom[0].name &&
> (machine->boot_order[0] == 'n' || !machine->kernel_filename)) {
> - uint8_t nolo_tags[0x10000];
> + uint8_t *nolo_tags = g_new(uint8_t, 0x10000);
> /* No, wait, better start at the ROM. */
> s->mpu->cpu->env.regs[15] = OMAP2_Q2_BASE + 0x400000;
>
> @@ -1383,6 +1383,7 @@ static void n8x0_init(MachineState *machine,
>
> n800_setup_nolo_tags(nolo_tags);
> cpu_physical_memory_write(OMAP2_SRAM_BASE, nolo_tags, 0x10000);
> + g_free(nolo_tags);
> }
> }
Thanks, applied to target-arm.next.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-04 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-26 6:15 [Qemu-trivial] [PATCH] hw/arm/nseries: Allocating Large sized arrays to heap Zhou Jie
2016-05-04 15:22 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).