From: Jan Vesely <jano.vesely@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Fri, 29 Apr 2016 13:14:51 -0400 [thread overview]
Message-ID: <1461950091.4285.2.camel@gmail.com> (raw)
In-Reply-To: <CAFEAcA-gYp9TS=JrEGgnP8uwXGuhcUzq5+wgdTDhigTyDNND9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
On Fri, 2016-04-29 at 15:49 +0100, Peter Maydell wrote:
> On 29 April 2016 at 15:31, Stefan Weil <sw@weilnetz.de> wrote:
> >
> > Is it a bug of the system headers? Or simply a design which
> > requires users to be careful when including certain header files?
> >
> > Both /usr/include/xfs/xfs_fs.h and /usr/include/linux/fs.h define
> > the same struct fsxattr, and both definitions are identical.
> That sounds like a header bug to me...
>
> http://oss.sgi.com/archives/xfs/2016-02/msg00324.html
>
> suggests that (a) the xfsprogs folks are updating their
> header to deal with what the kernel header is doing and that
> (b) they think the distros ought to be updating both of them
> in sync in some way...
yes, even more so that xfsprogs/xfslib will fail to compile using
linux-headers-4.5 for the very same reason. However, it looks like
distros are not keen on keeping them in sync.
the patch is a workaround.
Jan
>
> >
> > Of course a good comment would be helpful here, e. g.
> >
> > # Avoid redefinition of struct fsxattr in xfs/xfs_fs.h.
> > # It is already defined in linux/fs.h.
> Yes, this is really all I want: a note that some versions of
> the kernel headers and the xfs headers clash, so we suppress
> the xfs version if the kernel header is providing the struct.
>
> thanks
> -- PMM
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-29 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 13:07 [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header Jan Vesely
2016-04-29 13:54 ` Peter Maydell
2016-04-29 13:56 ` Stefan Weil
2016-04-29 14:00 ` Peter Maydell
2016-04-29 14:31 ` Stefan Weil
2016-04-29 14:49 ` Peter Maydell
2016-04-29 17:14 ` Jan Vesely [this message]
2016-04-29 17:15 ` [Qemu-trivial] [PATCH v2] " Jan Vesely
2016-05-02 12:07 ` Peter Maydell
2016-04-29 13:54 ` [Qemu-trivial] [PATCH] " Stefan Weil
2016-05-02 12:18 ` Michael Tokarev
2016-05-02 12:30 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 1:18 Jan Vesely
2016-04-12 21:09 ` Jan Vesely
2016-04-29 0:54 ` Jan Vesely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461950091.4285.2.camel@gmail.com \
--to=jano.vesely@gmail.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).