qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Sascha Silbe <x-qemu@se-silbe.de>,
	qemu-trivial@nongnu.org, Michael Tsirkin <mst@redhat.com>,
	qemu-ppc@nongnu.org, Victor Kaplansky <victork@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-trivial] [PATCH 1/3] tests/boot-sector: Use minimum length for the Forth boot script
Date: Tue, 11 Oct 2016 17:19:35 +0200	[thread overview]
Message-ID: <1476199177-32411-2-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1476199177-32411-1-git-send-email-thuth@redhat.com>

The pxe-test is quite slow on ppc64 with tcg. We can speed it up
a little bit by decreasing the size of the file that has to be
loaded via TFTP.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/boot-sector.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/boot-sector.c b/tests/boot-sector.c
index e3193c0..0168fd0 100644
--- a/tests/boot-sector.c
+++ b/tests/boot-sector.c
@@ -72,6 +72,7 @@ static uint8_t boot_sector[0x7e000] = {
 int boot_sector_init(const char *fname)
 {
     FILE *f = fopen(fname, "w");
+    size_t len = sizeof boot_sector;
 
     if (!f) {
         fprintf(stderr, "Couldn't open \"%s\": %s", fname, strerror(errno));
@@ -80,13 +81,12 @@ int boot_sector_init(const char *fname)
 
     /* For Open Firmware based system, we can use a Forth script instead */
     if (strcmp(qtest_get_arch(), "ppc64") == 0) {
-        memset(boot_sector, ' ', sizeof boot_sector);
-        sprintf((char *)boot_sector, "\\ Bootscript\n%x %x c! %x %x c!\n",
+        len = sprintf((char *)boot_sector, "\\ Bootscript\n%x %x c! %x %x c!\n",
                 LOW(SIGNATURE), BOOT_SECTOR_ADDRESS + SIGNATURE_OFFSET,
                 HIGH(SIGNATURE), BOOT_SECTOR_ADDRESS + SIGNATURE_OFFSET + 1);
     }
 
-    fwrite(boot_sector, 1, sizeof boot_sector, f);
+    fwrite(boot_sector, 1, len, f);
     fclose(f);
     return 0;
 }
-- 
1.8.3.1



  reply	other threads:[~2016-10-11 15:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 15:19 [Qemu-trivial] [PATCH 0/3] Improvements for the boot-sector tester Thomas Huth
2016-10-11 15:19 ` Thomas Huth [this message]
2016-10-11 15:58   ` [Qemu-trivial] [Qemu-devel] [PATCH 1/3] tests/boot-sector: Use minimum length for the Forth boot script Eric Blake
2016-10-11 15:19 ` [Qemu-trivial] [PATCH 2/3] tests/boot-sector: Use mkstemp() to create a unique file name Thomas Huth
2016-10-14  2:50   ` [Qemu-trivial] [Qemu-devel] " Fam Zheng
2016-10-11 15:19 ` [Qemu-trivial] [PATCH 3/3] tests/boot-sector: Increase time-out to 90 seconds Thomas Huth
2016-10-11 21:05 ` [Qemu-trivial] [PATCH 0/3] Improvements for the boot-sector tester Michael S. Tsirkin
2016-10-11 23:25   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476199177-32411-2-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=victork@redhat.com \
    --cc=x-qemu@se-silbe.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).