[Qemu-trivial] [PATCH] ui/gtk: Fix non-working DELETE key

[Qemu-trivial] [PATCH] ui/gtk: Fix non-working DELETE key

[Thomas Huth]

GTK generates key events for the delete key with key->string[0] = 0x7f
... but this does not work right with the readline_handle_byte()
function in util/readline.c, since this treats the keycode 127 as
backspace. So let's add a special case for the GTK delete key to make
this key behave right in the monitor interface of the GTK ui.

Buglink: https://bugs.launchpad.net/qemu/+bug/1619438
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 ui/gtk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 25e6d99..ab280e4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1051,7 +1051,9 @@ static gboolean gd_text_key_down(GtkWidget *widget,
     VirtualConsole *vc = opaque;
     QemuConsole *con = vc->gfx.dcl.con;
 
-    if (key->length) {
+    if (key->keyval == GDK_KEY_Delete) {
+        kbd_put_qcode_console(con, Q_KEY_CODE_DELETE);
+    } else if (key->length) {
         kbd_put_string_console(con, key->string, key->length);
     } else {
         int num = gd_map_keycode(vc->s, gtk_widget_get_display(widget),
-- 
1.8.3.1

Re: [Qemu-trivial] [PATCH] ui/gtk: Fix non-working DELETE key

[Gerd Hoffmann]

On Do, 2016-10-27 at 14:17 +0200, Thomas Huth wrote:
> GTK generates key events for the delete key with key->string[0] = 0x7f
> ... but this does not work right with the readline_handle_byte()
> function in util/readline.c, since this treats the keycode 127 as
> backspace. So let's add a special case for the GTK delete key to make
> this key behave right in the monitor interface of the GTK ui.

added to ui queue.

thanks,
  Gerd