[Qemu-trivial] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

[Qemu-trivial] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

[Thomas Huth]

The "or-irq" device needs to be wired up in source code, there is no
way the user can add this device with the "-device" parameter or the
"device_add" monitor command yet.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 v2: Changed patch description and comment

 hw/core/or-irq.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c
index 1ac090d..808c8d1 100644
--- a/hw/core/or-irq.c
+++ b/hw/core/or-irq.c
@@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data)
     dc->props = or_irq_properties;
     dc->realize = or_irq_realize;
     dc->vmsd = &vmstate_or_irq;
+
+    /* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */
+    dc->cannot_instantiate_with_device_add_yet = true;
 }
 
 static const TypeInfo or_irq_type_info = {
-- 
1.8.3.1

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

[Markus Armbruster]

Thomas Huth <thuth@redhat.com> writes:

> The "or-irq" device needs to be wired up in source code, there is no
> way the user can add this device with the "-device" parameter or the
> "device_add" monitor command yet.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Changed patch description and comment
>
>  hw/core/or-irq.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c
> index 1ac090d..808c8d1 100644
> --- a/hw/core/or-irq.c
> +++ b/hw/core/or-irq.c
> @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data)
>      dc->props = or_irq_properties;
>      dc->realize = or_irq_realize;
>      dc->vmsd = &vmstate_or_irq;
> +
> +    /* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */

This line is a bit long, and it could be shortened easily: drop "in
source code", or replace it by "to work".  This is how similar comments
elsewhere are phrased.

> +    dc->cannot_instantiate_with_device_add_yet = true;
>  }
>  
>  static const TypeInfo or_irq_type_info = {

Preferably with the comment touched up:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> Thomas Huth <thuth@redhat.com> writes:
>
>> The "or-irq" device needs to be wired up in source code, there is no
>> way the user can add this device with the "-device" parameter or the
>> "device_add" monitor command yet.

Well, the user can (I tried), but it won't do squat then.

>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  v2: Changed patch description and comment
>>
>>  hw/core/or-irq.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c
>> index 1ac090d..808c8d1 100644
>> --- a/hw/core/or-irq.c
>> +++ b/hw/core/or-irq.c
>> @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data)
>>      dc->props = or_irq_properties;
>>      dc->realize = or_irq_realize;
>>      dc->vmsd = &vmstate_or_irq;
>> +
>> +    /* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */
>
> This line is a bit long, and it could be shortened easily: drop "in
> source code", or replace it by "to work".  This is how similar comments
> elsewhere are phrased.
>
>> +    dc->cannot_instantiate_with_device_add_yet = true;
>>  }
>>  
>>  static const TypeInfo or_irq_type_info = {
>
> Preferably with the comment touched up:

Commit message, too.

> Reviewed-by: Markus Armbruster <armbru@redhat.com>