From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cbWVK-0001ws-Mw for mharc-qemu-trivial@gnu.org; Wed, 08 Feb 2017 12:58:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWVI-0001tW-S3 for qemu-trivial@nongnu.org; Wed, 08 Feb 2017 12:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbWVI-0004Cc-7y for qemu-trivial@nongnu.org; Wed, 08 Feb 2017 12:58:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55874) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbWV5-000411-VT; Wed, 08 Feb 2017 12:57:59 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 096813A7683; Wed, 8 Feb 2017 17:57:52 +0000 (UTC) Received: from thh440s.redhat.com (ovpn-116-87.ams2.redhat.com [10.36.116.87]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v18HvoYX031375; Wed, 8 Feb 2017 12:57:50 -0500 From: Thomas Huth To: Alistair Francis , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Markus Armbruster Date: Wed, 8 Feb 2017 18:57:49 +0100 Message-Id: <1486576669-29760-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 08 Feb 2017 17:57:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-trivial] [PATCH v3] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 17:58:05 -0000 The "or-irq" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet. Signed-off-by: Thomas Huth --- v3: Another update to the patch description and comment hw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c index 1ac090d..1485d5b 100644 --- a/hw/core/or-irq.c +++ b/hw/core/or-irq.c @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + + /* Reason: Needs to be wired up to work, e.g. see stm32f205_soc.c */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo or_irq_type_info = { -- 1.8.3.1