* [Qemu-trivial] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check
@ 2017-06-26 15:25 Peter Maydell
2017-06-26 15:51 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-06-27 13:26 ` [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2017-06-26 15:25 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches
Our FORTIFY_SOURCE check assumes that $cxx refers to a working C++
compiler, with the result that if you don't happen to have one
then configure will spuriously print
configure: line 4685: c++: command not found
Fix this by adding a 'has $cxx' check.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index c571ad1..a435908 100755
--- a/configure
+++ b/configure
@@ -4681,7 +4681,7 @@ fi
if test "$fortify_source" != "no"; then
if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
fortify_source="no";
- elif test -n "$cxx" &&
+ elif test -n "$cxx" && has $cxx &&
echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
fortify_source="no";
else
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check
2017-06-26 15:25 [Qemu-trivial] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check Peter Maydell
@ 2017-06-26 15:51 ` Philippe Mathieu-Daudé
2017-06-27 13:26 ` [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-06-26 15:51 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
On 06/26/2017 12:25 PM, Peter Maydell wrote:
> Our FORTIFY_SOURCE check assumes that $cxx refers to a working C++
> compiler, with the result that if you don't happen to have one
> then configure will spuriously print
> configure: line 4685: c++: command not found
>
> Fix this by adding a 'has $cxx' check.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index c571ad1..a435908 100755
> --- a/configure
> +++ b/configure
> @@ -4681,7 +4681,7 @@ fi
> if test "$fortify_source" != "no"; then
> if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> fortify_source="no";
> - elif test -n "$cxx" &&
> + elif test -n "$cxx" && has $cxx &&
> echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
> fortify_source="no";
> else
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check
2017-06-26 15:25 [Qemu-trivial] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check Peter Maydell
2017-06-26 15:51 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
@ 2017-06-27 13:26 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-06-27 13:26 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
Applied to trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-27 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-26 15:25 [Qemu-trivial] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check Peter Maydell
2017-06-26 15:51 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-06-27 13:26 ` [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).