Re: [PATCH 01/16] qemu/bswap: Undefine CPU_CONVERT() once done

Re: [PATCH 01/16] qemu/bswap: Undefine CPU_CONVERT() once done

[Thomas Huth]

On 04/10/2024 01.41, Philippe Mathieu-Daudé wrote:
> Better undefined macros once we are done with them,
> like we do few lines later with DO_STN_LDN_P().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/qemu/bswap.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index ad22910a5d1..b915835bead 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -140,6 +140,8 @@ CPU_CONVERT(le, 16, uint16_t)
>   CPU_CONVERT(le, 32, uint32_t)
>   CPU_CONVERT(le, 64, uint64_t)
>   
> +#undef CPU_CONVERT
> +

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 02/16] exec/memop: Remove unused memop_big_endian() helper

[Thomas Huth]

On 04/10/2024 01.41, Philippe Mathieu-Daudé wrote:
> Last use of memop_big_endian() was removed in commit 592134617c9
> ("accel/tcg: Reorg system mode store helpers").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/memop.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/include/exec/memop.h b/include/exec/memop.h
> index f881fe7af4e..899ea0a2aae 100644
> --- a/include/exec/memop.h
> +++ b/include/exec/memop.h
> @@ -164,10 +164,4 @@ static inline MemOp size_memop(unsigned size)
>       return (MemOp)ctz32(size);
>   }
>   
> -/* Big endianness from MemOp.  */
> -static inline bool memop_big_endian(MemOp op)
> -{
> -    return (op & MO_BSWAP) == MO_BE;
> -}
> -
>   #endif

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 03/16] linux-user/i386: Use explicit little-endian LD/ST API

[Thomas Huth]

On 04/10/2024 01.41, Philippe Mathieu-Daudé wrote:
> The x86 architecture uses little endianness. Directly use
> the little-endian LD/ST API.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   linux-user/i386/signal.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/i386/signal.c b/linux-user/i386/signal.c
> index cb90711834f..0f11dba831f 100644
> --- a/linux-user/i386/signal.c
> +++ b/linux-user/i386/signal.c
> @@ -754,8 +754,8 @@ static bool restore_sigcontext(CPUX86State *env, struct target_sigcontext *sc)
>       env->eip = tswapl(sc->rip);
>   #endif
>   
> -    cpu_x86_load_seg(env, R_CS, lduw_p(&sc->cs) | 3);
> -    cpu_x86_load_seg(env, R_SS, lduw_p(&sc->ss) | 3);
> +    cpu_x86_load_seg(env, R_CS, lduw_le_p(&sc->cs) | 3);
> +    cpu_x86_load_seg(env, R_SS, lduw_le_p(&sc->ss) | 3);
>   
>       tmpflags = tswapl(sc->eflags);
>       env->eflags = (env->eflags & ~0x40DD5) | (tmpflags & 0x40DD5);

Reviewed-by: Thomas Huth <thuth@redhat.com>