* [Qemu-trivial] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8
@ 2012-02-22 2:07 陳韋任
2012-02-23 3:43 ` [Qemu-trivial] [Qemu-devel] " 陳韋任
0 siblings, 1 reply; 2+ messages in thread
From: 陳韋任 @ 2012-02-22 2:07 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
helper, but introduces dependency issue at the same time. While building target
xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
at the moment. Explicitly declaring the dependency for the helper in the
Makefile.
Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
---
v2: Explicitly declaring the dependency for the helper instead of relying on
ordering side-effects.
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index e66e885..1b2488c 100644
--- a/Makefile
+++ b/Makefile
@@ -36,7 +36,7 @@ $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/hw)
LIBS+=-lz $(LIBS_TOOLS)
-HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
+HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF)
ifdef BUILD_DOCS
DOCS=qemu-doc.html qemu-tech.html qemu.1 qemu-img.1 qemu-nbd.8 QMP/qmp-commands.txt
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8
2012-02-22 2:07 [Qemu-trivial] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 陳韋任
@ 2012-02-23 3:43 ` 陳韋任
0 siblings, 0 replies; 2+ messages in thread
From: 陳韋任 @ 2012-02-23 3:43 UTC (permalink / raw)
To: stefanha; +Cc: qemu-trivial, qemu-devel
Hi Stefan,
Peter already fix this issue [1]. Please ignore my patch, thanks!
Regards,
chenwj
[1] http://patchwork.ozlabs.org/patch/142306/
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-23 3:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-22 2:07 [Qemu-trivial] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 陳韋任
2012-02-23 3:43 ` [Qemu-trivial] [Qemu-devel] " 陳韋任
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).