From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS
Date: Tue, 10 Apr 2012 13:59:57 +0100 [thread overview]
Message-ID: <20120410125957.GB9094@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1333555395-12873-1-git-send-email-peter.maydell@linaro.org>
On Wed, Apr 04, 2012 at 05:03:15PM +0100, Peter Maydell wrote:
> Remove some useless uses of ARCH_CFLAGS -- this variable was never set
> so will always be empty. The uses were accidental: in commit 0c439cbf8
> Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
> became QEMU_CFLAGS). However in commit be17dc90 a use of it was
> reintroduced (apparently accidentally) by Michael S. Tsirkin, and then
> I subsequently cut-n-pasted that into a number of other configure
> feature tests.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> configure | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2012-04-10 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 16:03 [Qemu-trivial] [PATCH] configure: Remove useless uses of ARCH_CFLAGS Peter Maydell
2012-04-05 7:19 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2012-04-10 12:59 ` Stefan Hajnoczi [this message]
2012-04-11 13:30 ` [Qemu-trivial] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410125957.GB9094@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).