From: Amos Kong <akong@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
stefanha@linux.vnet.ibm.com
Subject: [Qemu-trivial] [PATCH] error.c: don't return value for void function
Date: Mon, 16 Apr 2012 15:32:49 +0800 [thread overview]
Message-ID: <20120416073249.13295.65065.stgit@dhcp-8-167.nay.redhat.com> (raw)
It is invalid to return a value from a function
returning void.
Signed-off-by: Amos Kong <akong@redhat.com>
---
error.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/error.c b/error.c
index d3455ab..a52b771 100644
--- a/error.c
+++ b/error.c
@@ -93,7 +93,7 @@ QDict *error_get_data(Error *err)
void error_set_field(Error *err, const char *field, const char *value)
{
QDict *dict = qdict_get_qdict(err->obj, "data");
- return qdict_put(dict, field, qstring_from_str(value));
+ qdict_put(dict, field, qstring_from_str(value));
}
void error_free(Error *err)
next reply other threads:[~2012-04-16 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 7:32 Amos Kong [this message]
2012-04-16 8:58 ` [Qemu-trivial] [PATCH] error.c: don't return value for void function Paolo Bonzini
2012-04-16 9:43 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416073249.13295.65065.stgit@dhcp-8-167.nay.redhat.com \
--to=akong@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).