qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported
@ 2012-04-12 15:56 Eduardo Elias Ferreira
  2012-04-16 10:28 ` Stefan Hajnoczi
  2012-04-16 10:30 ` Stefan Hajnoczi
  0 siblings, 2 replies; 5+ messages in thread
From: Eduardo Elias Ferreira @ 2012-04-12 15:56 UTC (permalink / raw)
  To: qemu-trivial

---
 spice-qemu-char.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 9bab4ac..ef44bc0 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -233,7 +233,7 @@ CharDriverState *qemu_chr_open_spice(QemuOpts *opts)
         }
     }
     if (subtype == NULL) {
-        fprintf(stderr, "spice-qemu-char: unsupported name\n");
+        fprintf(stderr, "spice-qemu-char: unsupported name: %s\n", name);
         print_allowed_subtypes();
         return NULL;
     }
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported
  2012-04-12 15:56 [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported Eduardo Elias Ferreira
@ 2012-04-16 10:28 ` Stefan Hajnoczi
  2012-04-16 10:30 ` Stefan Hajnoczi
  1 sibling, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-04-16 10:28 UTC (permalink / raw)
  To: Eduardo Elias Ferreira; +Cc: qemu-trivial

On Thu, Apr 12, 2012 at 12:56:00PM -0300, Eduardo Elias Ferreira wrote:
> ---
>  spice-qemu-char.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported
  2012-04-12 15:56 [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported Eduardo Elias Ferreira
  2012-04-16 10:28 ` Stefan Hajnoczi
@ 2012-04-16 10:30 ` Stefan Hajnoczi
  1 sibling, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-04-16 10:30 UTC (permalink / raw)
  To: Eduardo Elias Ferreira; +Cc: qemu-trivial

On Thu, Apr 12, 2012 at 12:56:00PM -0300, Eduardo Elias Ferreira wrote:
> ---
>  spice-qemu-char.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Oops, I nearly missed it: this patch is missing your Signed-off-by:
line.  Please send your Signed-off-by: so this patch can be merged.

http://wiki.qemu.org/Contribute/SubmitAPatch

For more information on Signed-off-by:, please see:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297

Stefan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported
@ 2012-04-16 12:51 Eduardo Elias Ferreira
  2012-04-16 14:19 ` Stefan Hajnoczi
  0 siblings, 1 reply; 5+ messages in thread
From: Eduardo Elias Ferreira @ 2012-04-16 12:51 UTC (permalink / raw)
  To: qemu-trivial


Signed-off-by: Eduardo Elias Ferreira <edusf@linux.vnet.ibm.com>
---
 spice-qemu-char.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 9bab4ac..ef44bc0 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -233,7 +233,7 @@ CharDriverState *qemu_chr_open_spice(QemuOpts *opts)
         }
     }
     if (subtype == NULL) {
-        fprintf(stderr, "spice-qemu-char: unsupported name\n");
+        fprintf(stderr, "spice-qemu-char: unsupported name: %s\n", name);
         print_allowed_subtypes();
         return NULL;
     }
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported
  2012-04-16 12:51 Eduardo Elias Ferreira
@ 2012-04-16 14:19 ` Stefan Hajnoczi
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-04-16 14:19 UTC (permalink / raw)
  To: Eduardo Elias Ferreira; +Cc: qemu-trivial

On Mon, Apr 16, 2012 at 09:51:42AM -0300, Eduardo Elias Ferreira wrote:
> 
> Signed-off-by: Eduardo Elias Ferreira <edusf@linux.vnet.ibm.com>
> ---
>  spice-qemu-char.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-04-16 14:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-12 15:56 [Qemu-trivial] [PATCH] spice-qemu-char.c: Show what name is unsupported Eduardo Elias Ferreira
2012-04-16 10:28 ` Stefan Hajnoczi
2012-04-16 10:30 ` Stefan Hajnoczi
  -- strict thread matches above, loose matches on Subject: below --
2012-04-16 12:51 Eduardo Elias Ferreira
2012-04-16 14:19 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).