From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, afaerber@suse.de,
lcapitulino@redhat.com
Subject: Re: [Qemu-trivial] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze
Date: Fri, 20 Apr 2012 13:02:27 +0100 [thread overview]
Message-ID: <20120420120227.GA12878@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20120419154916.GD10190@illuin>
On Thu, Apr 19, 2012 at 10:49:16AM -0500, Michael Roth wrote:
> On Tue, Apr 17, 2012 at 12:07:38PM -0500, Michael Roth wrote:
> > When linux-specific commands (including guest-fsfreeze-*) were consolidated
> > under defined(__linux__), we forgot to account for the case where
> > defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer
> > being generated on linux hosts that don't have FIFREEZE support. Fix
> > this.
> >
> > Tested-by: Andreas Färber <afaerber@suse.de>
> > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
>
> Hi Stefan,
>
> Please ignore these for trivial, gonna submit a qemu-ga pull for these since
> a build fix is involved.
Sure.
Stefan
prev parent reply other threads:[~2012-04-20 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 17:07 [Qemu-trivial] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze Michael Roth
2012-04-17 17:07 ` [Qemu-trivial] [PATCH 2/2] qemu-ga: fix help output Michael Roth
2012-04-17 17:38 ` Luiz Capitulino
2012-04-17 17:35 ` [Qemu-trivial] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze Luiz Capitulino
2012-04-19 15:49 ` Michael Roth
2012-04-20 12:02 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420120227.GA12878@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).