From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Sat, 21 Jul 2012 10:37:46 +0100 [thread overview]
Message-ID: <20120721093746.GA13805@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <CAFEAcA9n7+UVp9W20x8zs71cPxZWBu8o1FQxVSwq8o6TdGZ0BQ@mail.gmail.com>
On Tue, Jul 17, 2012 at 08:28:40PM +0100, Peter Maydell wrote:
> On 17 July 2012 20:24, Stefan Weil <sw@weilnetz.de> wrote:
> > The arguments why -Werror is a bad idea for some configure tests
> > are reasonable.
> >
> > Nevertheless the QEMU community was able to produce thousands of
> > lines of code which compile without a warning, so we should be able
> > to create warning and error free code for a handful of configure
> > tests.
>
> The trouble is that the warnings and errors here don't cause the
> build to fail noisily; that's a big distinction IMHO.
> I suppose we could make compile_prog do something like:
> * run the compile test
> * if it fails => test failure as now
> * if it succeeds (and we're doing a Werror build at all),
> rerun the same test with -Werror
> * if that fails, abort configure with an error message
> Then we would have the same "make the problem obvious" effect
> that plain -Werror provides for our main compilation.
>
> > The 4 patches above are valid and can be applied with or without
> > -Werror, therefore qemu-trivial or whoever does not have to wait for
> > Peter's patch.
>
> Yes, I agree we might as well fix these errors since we've now
> noticed them, regardless of whether or not we apply my patch
> (which I've just sent).
Build/configure fixes should go straight into qemu.git.
Stefan
next prev parent reply other threads:[~2012-07-21 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342546459-21993-1-git-send-email-i.mitsyanko@samsung.com>
[not found] ` <5005A904.5000006@samsung.com>
2012-07-17 18:32 ` [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix ALSA configure test Stefan Weil
2012-07-17 18:46 ` Peter Maydell
2012-07-17 19:24 ` Stefan Weil
2012-07-17 19:28 ` Peter Maydell
2012-07-17 19:42 ` Stefan Weil
2012-07-21 9:37 ` Stefan Hajnoczi [this message]
2012-07-23 17:40 ` Blue Swirl
2012-07-23 17:45 ` Peter Maydell
2012-07-23 19:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120721093746.GA13805@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=i.mitsyanko@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).