From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis
Date: Wed, 5 Sep 2012 10:36:27 +0100 [thread overview]
Message-ID: <20120905093627.GC4786@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1346704840-9522-1-git-send-email-sw@weilnetz.de>
On Mon, Sep 03, 2012 at 10:40:40PM +0200, Stefan Weil wrote:
> Report from smatch:
>
> kvm-all.c:1373 kvm_init(135) warn:
> variable dereferenced before check 's' (see line 1360)
>
> 's' cannot by NULL (it was alloced using g_malloc0), so there is no need
> to check it here.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> kvm-all.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-09-05 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 20:40 [Qemu-trivial] [PATCH] kvm: Fix warning from static code analysis Stefan Weil
2012-09-03 21:10 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2012-09-05 9:36 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905093627.GC4786@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).