From: Stefan Hajnoczi <stefanha@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, jbaron@redhat.com, somlo@cmu.edu,
qemu-devel@nongnu.org, "Gabriel L. Somlo" <gsomlo@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled
Date: Fri, 16 Nov 2012 14:50:24 +0100 [thread overview]
Message-ID: <20121116135024.GB31927@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20121112144918.GA2107@hedwig.ini.cmu.edu>
On Mon, Nov 12, 2012 at 09:49:19AM -0500, Gabriel L. Somlo wrote:
> This patch fixes a few debugging print statements whose arguments fell
> out of sync over time with changes being made to the active code base.
>
> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> ---
>
> On Mon, Nov 12, 2012 at 11:26:18AM +0100, Gerd Hoffmann wrote:
> > Seems macos doesn't like something in our ehci emulation ...
> > Can you send a trace with all ehci tracepoints enabled?
>
> Turning EHCI_DEBUG on gave me compile errors. This is my best guess
> as to what the DPRINTF arguments *should* be, hope I guessed right :)
In that case I'll let Gerd confirm whether or not the guesses are
correct.
Gerd: can you review and take this through the USB tree?
Thanks,
Stefan
next prev parent reply other threads:[~2012-11-16 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121111221650.GA3575@foober.ini.cmu.edu>
[not found] ` <50A0CECA.9060102@redhat.com>
2012-11-12 14:49 ` [Qemu-trivial] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled Gabriel L. Somlo
2012-11-16 13:50 ` Stefan Hajnoczi [this message]
2012-11-16 13:54 ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116135024.GB31927@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=gsomlo@gmail.com \
--cc=jbaron@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).