From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1TbrkA-0007hl-4o for mharc-qemu-trivial@gnu.org; Fri, 23 Nov 2012 06:48:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbrk4-0007hc-Nc for qemu-trivial@nongnu.org; Fri, 23 Nov 2012 06:48:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tbrk0-00051o-Bc for qemu-trivial@nongnu.org; Fri, 23 Nov 2012 06:48:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbrk0-00051h-3c; Fri, 23 Nov 2012 06:48:16 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qANBmEu1005219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Nov 2012 06:48:14 -0500 Received: from doriath.home (ovpn-113-34.phx2.redhat.com [10.3.113.34]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qANBmBpW017216; Fri, 23 Nov 2012 06:48:12 -0500 Date: Fri, 23 Nov 2012 09:48:12 -0200 From: Luiz Capitulino To: Stefan Hajnoczi Message-ID: <20121123094812.49dccb4c@doriath.home> In-Reply-To: <20121123065049.GB22787@stefanha-thinkpad.hitronhub.home> References: <1353420681-8870-1-git-send-email-brogers@suse.com> <87lidwux0q.fsf@blackfin.pond.sub.org> <50ACC545.7000002@siemens.com> <20121122103411.0eefef6a@doriath.home> <20121123065049.GB22787@stefanha-thinkpad.hitronhub.home> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, Jan Kiszka , Marcelo Tosatti , "qemu-devel@nongnu.org" , Markus Armbruster , Bruce Rogers Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2012 11:48:25 -0000 On Fri, 23 Nov 2012 07:50:49 +0100 Stefan Hajnoczi wrote: > On Thu, Nov 22, 2012 at 10:34:11AM -0200, Luiz Capitulino wrote: > > On Wed, 21 Nov 2012 13:12:53 +0100 > > Jan Kiszka wrote: > > > > > On 2012-11-20 16:14, Markus Armbruster wrote: > > > > Cc'ing Marcelo & Jan to speed up patch application. > > > > > > > > Bruce Rogers writes: > > > > > > > >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip > > > >> should be marked as having no argument. > > > >> > > > >> Signed-off-by: Bruce Rogers > > > >> --- > > > >> qemu-options.hx | 8 ++++---- > > > >> 1 files changed, 4 insertions(+), 4 deletions(-) > > > >> > > > >> diff --git a/qemu-options.hx b/qemu-options.hx > > > >> index 9bb29d3..fbcf079 100644 > > > >> --- a/qemu-options.hx > > > >> +++ b/qemu-options.hx > > > >> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode. > > > >> ETEXI > > > >> > > > >> HXCOMM Deprecated by -machine accel=tcg property > > > >> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > > > >> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > > > >> > > > >> HXCOMM Deprecated by kvm-pit driver properties > > > >> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection, > > > >> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection, > > > >> "", QEMU_ARCH_I386) > > > >> > > > >> HXCOMM Deprecated (ignored) > > > >> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > > > >> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > > > >> > > > >> HXCOMM Deprecated by -machine kernel_irqchip=on|off property > > > >> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) > > > >> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) > > > >> > > > >> HXCOMM Deprecated (ignored) > > > >> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL) > > > > > > Reviewed-by: Jan Kiszka > > > > Candidate for -trivial. > > This is more urgent than trivial. It is necessary for qemu-kvm > compatibility and I think should go into QEMU 1.3. Otherwise we have to > wait until QEMU 1.4 to complete the qemu-kvm -> qemu transition. That's true, I missed the fact that you don't do pull requests during hard freeze... Thanks!