qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ben Leslie <benno@benno.id.au>
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts.
Date: Fri, 12 Apr 2013 13:15:50 +0200	[thread overview]
Message-ID: <20130412111550.GA9747@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CABZ0LtBxD4CvG4wFAE_S+Zr8OeWuq1PGGt+d7MZJ61DNKYTNdg@mail.gmail.com>

On Sun, Apr 07, 2013 at 03:20:44PM +1000, Ben Leslie wrote:
> The user should not be allowed to configure a softmmu target
> when --disable-system is selected.
> 
> Signed-off-by: Ben Leslie <benno@benno.id.au>
> ---
>  configure | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d685275..e4288ed 100755
> --- a/configure
> +++ b/configure
> @@ -1353,7 +1353,13 @@ else
>  fi
>  # see if system emulation was really requested
>  case " $target_list " in
> -  *"-softmmu "*) softmmu=yes
> +  *"-softmmu "*)
> +    if test "$softmmu" = "no"; then
> +      echo "ERROR: System emulation disabled (via --disable-system),
> however a "
> +      echo "       system emulation target specified in --target-list."
> +      exit 1
> +    fi
> +    softmmu=yes

Please use the new error_exit function.  Fine otherwise.

Stefan


      reply	other threads:[~2013-04-12 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07  5:20 [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts Ben Leslie
2013-04-12 11:15 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130412111550.GA9747@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=benno@benno.id.au \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).