* [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts.
@ 2013-04-07 5:20 Ben Leslie
2013-04-12 11:15 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Ben Leslie @ 2013-04-07 5:20 UTC (permalink / raw)
To: qemu-trivial
The user should not be allowed to configure a softmmu target
when --disable-system is selected.
Signed-off-by: Ben Leslie <benno@benno.id.au>
---
configure | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index d685275..e4288ed 100755
--- a/configure
+++ b/configure
@@ -1353,7 +1353,13 @@ else
fi
# see if system emulation was really requested
case " $target_list " in
- *"-softmmu "*) softmmu=yes
+ *"-softmmu "*)
+ if test "$softmmu" = "no"; then
+ echo "ERROR: System emulation disabled (via --disable-system),
however a "
+ echo " system emulation target specified in --target-list."
+ exit 1
+ fi
+ softmmu=yes
;;
*) softmmu=no
;;
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts.
2013-04-07 5:20 [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts Ben Leslie
@ 2013-04-12 11:15 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-04-12 11:15 UTC (permalink / raw)
To: Ben Leslie; +Cc: qemu-trivial
On Sun, Apr 07, 2013 at 03:20:44PM +1000, Ben Leslie wrote:
> The user should not be allowed to configure a softmmu target
> when --disable-system is selected.
>
> Signed-off-by: Ben Leslie <benno@benno.id.au>
> ---
> configure | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index d685275..e4288ed 100755
> --- a/configure
> +++ b/configure
> @@ -1353,7 +1353,13 @@ else
> fi
> # see if system emulation was really requested
> case " $target_list " in
> - *"-softmmu "*) softmmu=yes
> + *"-softmmu "*)
> + if test "$softmmu" = "no"; then
> + echo "ERROR: System emulation disabled (via --disable-system),
> however a "
> + echo " system emulation target specified in --target-list."
> + exit 1
> + fi
> + softmmu=yes
Please use the new error_exit function. Fine otherwise.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-12 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-07 5:20 [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts Ben Leslie
2013-04-12 11:15 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).