From: David Gibson <dwg@au1.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
qemu-ppc@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-ppc] [PATCH v2] bswap: fix compiler warning
Date: Mon, 15 Apr 2013 11:52:32 +1000 [thread overview]
Message-ID: <20130415015232.GB16400@truffula.fritz.box> (raw)
In-Reply-To: <1365990476-14975-1-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Mon, Apr 15, 2013 at 11:47:56AM +1000, Alexey Kardashevskiy wrote:
> The bswap functions use memcpy but the bswap.h header itself does not seem to
> include it in some configuration such as cross compiling for powerpc64
> on x86_64 machine.
>
> The patch explicitly includes string.h.
>
> v2:
> * #include statement moved to the right place
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-04-15 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1365730875-22854-1-git-send-email-aik@ozlabs.ru>
[not found] ` <5167E747.2020106@suse.de>
[not found] ` <20130412164715.GL5065@truffula.fritz.box>
[not found] ` <51684621.7090204@weilnetz.de>
[not found] ` <51686D39.3070209@ozlabs.ru>
2013-04-12 20:31 ` [Qemu-trivial] [Qemu-devel] [PATCH] bswap: fix compiler warning Stefan Weil
2013-04-15 1:47 ` [Qemu-trivial] [PATCH v2] " Alexey Kardashevskiy
2013-04-15 1:52 ` David Gibson [this message]
2013-04-15 10:52 ` Andreas Färber
2013-04-19 9:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415015232.GB16400@truffula.fritz.box \
--to=dwg@au1.ibm.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).