From: Aurelien Jarno <aurelien@aurel32.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes
Date: Sun, 4 May 2014 23:30:37 +0200 [thread overview]
Message-ID: <20140504213037.GA25769@hall.aurel32.net> (raw)
In-Reply-To: <1399062573-2769-1-git-send-email-sw@weilnetz.de>
On Fri, May 02, 2014 at 10:29:33PM +0200, Stefan Weil wrote:
> This fixes a warning from the static code analysis (smatch).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/mips/mips_fulong2e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index e1551aa..30d9f19 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -211,7 +211,7 @@ static void main_cpu_reset(void *opaque)
> }
> }
>
> -uint8_t eeprom_spd[0x80] = {
> +static const uint8_t eeprom_spd[0x80] = {
> 0x80,0x08,0x07,0x0d,0x09,0x02,0x40,0x00,0x04,0x70,
> 0x70,0x00,0x82,0x10,0x00,0x01,0x0e,0x04,0x0c,0x01,
> 0x02,0x20,0x80,0x75,0x70,0x00,0x00,0x50,0x3c,0x50,
Acked-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2014-05-04 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 20:29 [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes Stefan Weil
2014-05-03 9:05 ` Michael Tokarev
2014-05-04 21:30 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140504213037.GA25769@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).