* [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes
@ 2014-05-02 20:29 Stefan Weil
2014-05-03 9:05 ` Michael Tokarev
2014-05-04 21:30 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2014-05-02 20:29 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
This fixes a warning from the static code analysis (smatch).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/mips/mips_fulong2e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index e1551aa..30d9f19 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -211,7 +211,7 @@ static void main_cpu_reset(void *opaque)
}
}
-uint8_t eeprom_spd[0x80] = {
+static const uint8_t eeprom_spd[0x80] = {
0x80,0x08,0x07,0x0d,0x09,0x02,0x40,0x00,0x04,0x70,
0x70,0x00,0x82,0x10,0x00,0x01,0x0e,0x04,0x0c,0x01,
0x02,0x20,0x80,0x75,0x70,0x00,0x00,0x50,0x3c,0x50,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes
2014-05-02 20:29 [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes Stefan Weil
@ 2014-05-03 9:05 ` Michael Tokarev
2014-05-04 21:30 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-05-03 9:05 UTC (permalink / raw)
To: Stefan Weil, qemu-trivial; +Cc: qemu-devel
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes
2014-05-02 20:29 [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes Stefan Weil
2014-05-03 9:05 ` Michael Tokarev
@ 2014-05-04 21:30 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2014-05-04 21:30 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Fri, May 02, 2014 at 10:29:33PM +0200, Stefan Weil wrote:
> This fixes a warning from the static code analysis (smatch).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/mips/mips_fulong2e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index e1551aa..30d9f19 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -211,7 +211,7 @@ static void main_cpu_reset(void *opaque)
> }
> }
>
> -uint8_t eeprom_spd[0x80] = {
> +static const uint8_t eeprom_spd[0x80] = {
> 0x80,0x08,0x07,0x0d,0x09,0x02,0x40,0x00,0x04,0x70,
> 0x70,0x00,0x82,0x10,0x00,0x01,0x0e,0x04,0x0c,0x01,
> 0x02,0x20,0x80,0x75,0x70,0x00,0x00,0x50,0x3c,0x50,
Acked-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-04 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-02 20:29 [Qemu-trivial] [PATCH] hw/mips: Add missing 'static' and 'const' attributes Stefan Weil
2014-05-03 9:05 ` Michael Tokarev
2014-05-04 21:30 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).