qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
* Re: [Qemu-trivial] [PATCH] migration: fix bad string passed to error_report()
       [not found] ` <20160204100011.GC20527@grmbl.mre>
@ 2016-02-04 10:18   ` Greg Kurz
  0 siblings, 0 replies; only message in thread
From: Greg Kurz @ 2016-02-04 10:18 UTC (permalink / raw)
  To: Amit Shah; +Cc: qemu-trivial, qemu-stable, qemu-devel, Juan Quintela

On Thu, 4 Feb 2016 15:30:11 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Thu) 04 Feb 2016 [10:20:07], Greg Kurz wrote:
> > state->name does not contain a terminating '\0' and you may get:
> > 
> > Machine type received is 'pseries-2.3y�?' and local is 'pseries-2.4'
> > load of migration failed: Invalid argument
> > 
> > Let's add a precision modifier to fix this.
> > 
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>  
> 
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> 		Amit
> 

I forgot to mention that this patch fixes:

61964c23e5ddd5a33f15699e45ce126f879e3e33 "migration: Add configuration section"

Cc'ing stable since this is a 2.4.0 commit and it may *theorically* lead to
a crash (even if that is very unlikely to occur).

Also Cc'ing trivial.

Thanks !

--
Greg



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-04 10:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160204092007.31588.66396.stgit@bahia.huguette.org>
     [not found] ` <20160204100011.GC20527@grmbl.mre>
2016-02-04 10:18   ` [Qemu-trivial] [PATCH] migration: fix bad string passed to error_report() Greg Kurz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).