From: Wei Yang <richard.weiyang@gmail.com>
To: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
qemu-devel@nongnu.org, Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries
Date: Tue, 23 Feb 2016 22:24:15 +0000 [thread overview]
Message-ID: <20160223222415.GA11962@vultr.guest> (raw)
In-Reply-To: <20160223141711.277bfb16@oc0525210443>
On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote:
>于 Mon, 22 Feb 2016 14:15:07 +0100
>Christian Borntraeger <borntraeger@de.ibm.com> 写道:
>
>> On 02/19/2016 04:18 PM, Wei Yang wrote:
>> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is
>> > the more proper on retrieving MSIX entries.
>> >
>> > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries.
>> >
>> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> > CC: Cornelia Huck <cornelia.huck@de.ibm.com>
>> > CC: Christian Borntraeger <borntraeger@de.ibm.com>
>> > ---
>> > hw/s390x/s390-pci-bus.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
>> > index 132588b..9d40039 100644
>> > --- a/hw/s390x/s390-pci-bus.c
>> > +++ b/hw/s390x/s390-pci-bus.c
>> > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev)
>> > return 0;
>> > }
>> >
>> > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS,
>> > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS,
>> > pci_config_size(pbdev->pdev), sizeof(ctrl));
>> > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE,
>> > pci_config_size(pbdev->pdev), sizeof(table));
>> >
>>
>> looks sane.
>> Yi Min, can you ack/nack?
>>
>>
>
>It looks sane to me. A little change.
Thanks Yi Min and Christian.
So someone would pick it up?
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2016-02-23 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 15:18 [Qemu-trivial] [PATCH 0/2] use PCI_MSIX_FLAGS on retrieving the MSIX entries Wei Yang
2016-02-19 15:18 ` [Qemu-trivial] [PATCH 1/2] vfio/pci: " Wei Yang
2016-02-19 16:45 ` [Qemu-trivial] [Qemu-devel] " Alex Williamson
2016-02-19 23:38 ` Wei Yang
2016-02-19 15:18 ` [Qemu-trivial] [PATCH 2/2] s390x/pci: " Wei Yang
2016-02-22 13:15 ` Christian Borntraeger
2016-02-23 6:17 ` Yi Min Zhao
2016-02-23 22:24 ` Wei Yang [this message]
2016-02-24 9:40 ` Cornelia Huck
2016-02-24 14:29 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223222415.GA11962@vultr.guest \
--to=richard.weiyang@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).