From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
Date: Mon, 19 Sep 2016 12:32:00 +0200 [thread overview]
Message-ID: <20160919123200.7bfecc1f.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <CAFEAcA-syR4mDW9JRD6NcJkeQd0Ue9ymf3CKcF6W1Shi-1VZmA@mail.gmail.com>
On Fri, 16 Sep 2016 16:45:06 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 16 September 2016 at 16:39, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote:
> >> On 16 September 2016 at 14:55, Laurent Vivier <lvivier@redhat.com> wrote:
> >> > This series is the result of coccinelle patch
> >> > scripts/coccinelle/exit.cocci
> >> > provided by the first patch of the series.
> >> >
> >> > It replaces exit(0) by exit(EXIT_SUCCESS)
> >> > and exit(1) by exit(EXIT_FAILURE).
> >> >
> >> > All other exit() are not modified as we don't want
> >> > to change the behavior.
> >> >
> >> > In some cases, I've added manually a line break to comply
> >> > with the maximum line length.
> >>
> >> > 182 files changed, 734 insertions(+), 715 deletions(-)
> >>
> >> You don't say why this is a useful change to make, and it's an
> >> awful lot of churn for a stylistic issue...
> >
> > Currently QEMU uses a mix of at least
> >
> > exit(EXIT_SUCCESS)
> > exit(EXIT_FAILURE)
> > exit(1)
> > exit(-1)
> > _exit(1)
> > _exit(0);
> >
> > so this series has the potential giving us more consistency style
> > and behaviour, across our code. By not fixing the up the usage of -1,
> > or fixing the _exit() usage, the series feels incomplete to me though.
>
> -1 is just a bug which we should fix (as Eric says). I don't
> see the point in converting all our 0s and 1s to EXIT_SUCCESS
> and EXIT_FAILURE though. (It would be less churn to convert the
> uses of EXIT_* to 0 and 1...)
Agreed.
If we want to make our exit handling more consistent, the first step
would be to examine whether doing an exit() is the right thing to do in
that code path at all. I'm currently aware at least of some exit()s in
the virtio code that need to be converted to real error handling, and
I'd not be surprised if similar things were true for other parts of the
code.
next prev parent reply other threads:[~2016-09-19 10:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 13:55 [Qemu-trivial] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) Laurent Vivier
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 01/26] coccinelle: " Laurent Vivier
2016-09-16 15:35 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 02/26] arm: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 03/26] cris: " Laurent Vivier
2016-09-16 14:41 ` Edgar E. Iglesias
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 04/26] block: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 05/26] ppc: " Laurent Vivier
2016-09-19 5:22 ` David Gibson
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 06/26] graphics: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 07/26] tests: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-trivial] [PATCH 08/26] replay: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 09/26] qemu-user: " Laurent Vivier
2016-09-21 19:21 ` Riku Voipio
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 10/26] m68k: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 11/26] pci, virtio: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 12/26] sparc: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 13/26] sh4: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 14/26] x86: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 15/26] mips: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 16/26] s390: " Laurent Vivier
2016-09-19 11:07 ` Cornelia Huck
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 17/26] tcg: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 18/26] posix: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 19/26] alpha: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 20/26] common: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 21/26] misc machine: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 22/26] blockdev: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 23/26] core: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 24/26] error, trace: " Laurent Vivier
2016-09-16 15:55 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 25/26] hw: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-trivial] [PATCH 26/26] net: " Laurent Vivier
2016-09-16 14:41 ` [Qemu-trivial] [Qemu-devel] [PATCH 00/26] trivial: " no-reply
2016-09-16 14:47 ` Peter Maydell
2016-09-16 15:39 ` Daniel P. Berrange
2016-09-16 15:45 ` Peter Maydell
2016-09-19 9:21 ` Markus Armbruster
2016-09-19 9:46 ` Laurent Vivier
2016-09-19 10:19 ` Peter Maydell
2016-09-19 10:32 ` Cornelia Huck [this message]
2016-09-16 15:27 ` Daniel P. Berrange
2016-09-16 15:39 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919123200.7bfecc1f.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).