From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1bmiua-0002BG-Oj for mharc-qemu-trivial@gnu.org; Wed, 21 Sep 2016 10:54:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmiuV-00025U-HA for qemu-trivial@nongnu.org; Wed, 21 Sep 2016 10:54:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmiuT-00081l-Cz for qemu-trivial@nongnu.org; Wed, 21 Sep 2016 10:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmiuL-0007qU-EU; Wed, 21 Sep 2016 10:53:57 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70B8D148A4; Wed, 21 Sep 2016 14:53:55 +0000 (UTC) Received: from localhost (ovpn-116-175.phx2.redhat.com [10.3.116.175]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8LErr7J031557; Wed, 21 Sep 2016 10:53:54 -0400 Date: Wed, 21 Sep 2016 10:50:49 -0400 From: Luiz Capitulino To: David Gibson Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, ehabkost@redhat.com, armbru@redhat.com, imammedo@redhat.com, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Message-ID: <20160921105049.55ede6b1@redhat.com> In-Reply-To: <1474435766-9727-1-git-send-email-david@gibson.dropbear.id.au> References: <1474435766-9727-1-git-send-email-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 21 Sep 2016 14:53:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [PATCH] monitor: fix crash for platforms without a CPU 0 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 14:54:11 -0000 On Wed, 21 Sep 2016 15:29:26 +1000 David Gibson wrote: > Now that we allow CPU hot unplug on a few platforms, we can end up in a > situation where we don't have a CPU with index 0. Or at least we could, > if we didn't have code to explicitly prohibit unplug of CPU 0. >=20 > Longer term we want to allow CPU 0 unplug, this patch is an early step in > allowing this, by removing an assumption in the monitor code that CPU 0 > always exists. >=20 > Signed-off-by: C=C3=A9dric Le Goater > [dwg: Rewrote commit message to better explain background] > Signed-off-by: David Gibson > --- > monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Anyone want to volunteer to take this through their tree? If not, I > can take it through my ppc tree. Please do. Reviewed-by: Luiz Capitulino >=20 > diff --git a/monitor.c b/monitor.c > index 8bb8bbf..83c4edf 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1025,7 +1025,7 @@ int monitor_set_cpu(int cpu_index) > CPUState *mon_get_cpu(void) > { > if (!cur_mon->mon_cpu) { > - monitor_set_cpu(0); > + monitor_set_cpu(first_cpu->cpu_index); > } > cpu_synchronize_state(cur_mon->mon_cpu); > return cur_mon->mon_cpu;