From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Akanksha Srivastava <akanksha.dlf@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] usb: Change *_exitfn return type from void to int
Date: Fri, 30 Sep 2016 20:06:24 +0200 [thread overview]
Message-ID: <20160930180624.fpmybtpkldpeehiu@latitude> (raw)
In-Reply-To: <1475257895-10762-1-git-send-email-akanksha.dlf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Fri, Sep 30, 2016 at 11:21:35PM +0530, Akanksha Srivastava wrote:
> Subject: [Qemu-devel] [PATCH] usb: Change *_exitfn return type from void to int
This should read "from int to void", I guess.
> The *_exitfn functions cannot fail and should not be
> returning int.
> Suggested as a Bite-sized task
> Signed-off-by: Akanksha Srivastava <akanksha.dlf@gmail.com>
> ---
> hw/usb/ccid-card-emulated.c | 4 ++--
> hw/usb/ccid-card-passthru.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
[...]
> -static int passthru_exitfn(CCIDCardState *base)
> +static void passthru_exitfn(CCIDCardState *base)
> {
> - return 0;
> + return;
> }
Have you compile-tested this change? I think you'll have to adjust the
definition of exitfn in CCIDCardClass, and ccid_card_exitfn (in
hw/usb/dev-smartcard-reader.c) as well.
Regards,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-30 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 17:51 [Qemu-trivial] [PATCH] usb: Change *_exitfn return type from void to int Akanksha Srivastava
2016-09-30 18:06 ` Jonathan Neuschäfer [this message]
2016-09-30 18:46 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930180624.fpmybtpkldpeehiu@latitude \
--to=j.neuschaefer@gmx.net \
--cc=akanksha.dlf@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).