From: Fam Zheng <famz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Victor Kaplansky <victork@redhat.com>,
Michael Tsirkin <mst@redhat.com>,
qemu-trivial@nongnu.org, qemu-ppc@nongnu.org,
Sascha Silbe <x-qemu@se-silbe.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] tests/boot-sector: Use mkstemp() to create a unique file name
Date: Fri, 14 Oct 2016 10:50:58 +0800 [thread overview]
Message-ID: <20161014025058.GA14830@lemon> (raw)
In-Reply-To: <1476199177-32411-3-git-send-email-thuth@redhat.com>
On Tue, 10/11 17:19, Thomas Huth wrote:
> The pxe-test is run for three different targets now (x86_64, i386
> and ppc64), and the bios-tables-test is run for two targets (x86_64
> and i386). But each of the tests is using an invariant name for the
> disk image with the boot sector code - so if the tests are running in
> parallel, there is a race condition that they destroy the disk image
> of a parallel test program. Let's use mkstemp() to create unique
> temporary files here instead - and since mkstemp() is returning an
> integer file descriptor instead of a FILE pointer, we also switch
> the fwrite() and fclose() to write() and close() instead.
>
> Reported-by: Sascha Silbe <x-qemu@se-silbe.de>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Tested-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2016-10-14 2:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 15:19 [Qemu-trivial] [PATCH 0/3] Improvements for the boot-sector tester Thomas Huth
2016-10-11 15:19 ` [Qemu-trivial] [PATCH 1/3] tests/boot-sector: Use minimum length for the Forth boot script Thomas Huth
2016-10-11 15:58 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2016-10-11 15:19 ` [Qemu-trivial] [PATCH 2/3] tests/boot-sector: Use mkstemp() to create a unique file name Thomas Huth
2016-10-14 2:50 ` Fam Zheng [this message]
2016-10-11 15:19 ` [Qemu-trivial] [PATCH 3/3] tests/boot-sector: Increase time-out to 90 seconds Thomas Huth
2016-10-11 21:05 ` [Qemu-trivial] [PATCH 0/3] Improvements for the boot-sector tester Michael S. Tsirkin
2016-10-11 23:25 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014025058.GA14830@lemon \
--to=famz@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=victork@redhat.com \
--cc=x-qemu@se-silbe.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).