* [Qemu-trivial] [PATCH] pci: fix some typos
@ 2016-11-11 1:37 Cao jin
2016-11-11 1:43 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Cao jin @ 2016-11-11 1:37 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: mst, marcel, alex.williamson
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/pci/pcie.c | 2 +-
hw/vfio/pci.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 99cfb45..39b10b8 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -656,7 +656,7 @@ static void pcie_ext_cap_set_next(PCIDevice *dev, uint16_t pos, uint16_t next)
}
/*
- * caller must supply valid (offset, size) * such that the range shouldn't
+ * Caller must supply valid (offset, size) such that the range wouldn't
* overlap with other capability or other registers.
* This function doesn't check it.
*/
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 31aaecb..c94987c 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1881,8 +1881,8 @@ static void vfio_add_ext_cap(VFIOPCIDevice *vdev)
* 0 is reserved for this since absence of capabilities is indicated by
* 0 for the ID, version, AND next pointer. However, pcie_add_capability()
* uses ID 0 as reserved for list management and will incorrectly match and
- * assert if we attempt to pre-load the head of the chain with with this
- * ID. Use ID 0xFFFF temporarily since it is also seems to be reserved in
+ * assert if we attempt to pre-load the head of the chain with this ID.
+ * Use ID 0xFFFF temporarily since it is also seems to be reserved in
* part for identifying absence of capabilities in a root complex register
* block. If the ID still exists after adding capabilities, switch back to
* zero. We'll mark this entire first dword as emulated for this purpose.
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [PATCH] pci: fix some typos
2016-11-11 1:37 [Qemu-trivial] [PATCH] pci: fix some typos Cao jin
@ 2016-11-11 1:43 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2016-11-11 1:43 UTC (permalink / raw)
To: Cao jin; +Cc: qemu-devel, qemu-trivial, mst, marcel
On Fri, 11 Nov 2016 09:37:58 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/pci/pcie.c | 2 +-
> hw/vfio/pci.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Send separate patches. Thanks,
Alex
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 99cfb45..39b10b8 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -656,7 +656,7 @@ static void pcie_ext_cap_set_next(PCIDevice *dev, uint16_t pos, uint16_t next)
> }
>
> /*
> - * caller must supply valid (offset, size) * such that the range shouldn't
> + * Caller must supply valid (offset, size) such that the range wouldn't
> * overlap with other capability or other registers.
> * This function doesn't check it.
> */
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 31aaecb..c94987c 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1881,8 +1881,8 @@ static void vfio_add_ext_cap(VFIOPCIDevice *vdev)
> * 0 is reserved for this since absence of capabilities is indicated by
> * 0 for the ID, version, AND next pointer. However, pcie_add_capability()
> * uses ID 0 as reserved for list management and will incorrectly match and
> - * assert if we attempt to pre-load the head of the chain with with this
> - * ID. Use ID 0xFFFF temporarily since it is also seems to be reserved in
> + * assert if we attempt to pre-load the head of the chain with this ID.
> + * Use ID 0xFFFF temporarily since it is also seems to be reserved in
> * part for identifying absence of capabilities in a root complex register
> * block. If the ID still exists after adding capabilities, switch back to
> * zero. We'll mark this entire first dword as emulated for this purpose.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-11 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-11 1:37 [Qemu-trivial] [PATCH] pci: fix some typos Cao jin
2016-11-11 1:43 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).