* [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements
@ 2017-01-18 8:03 Ziyue Yang
2017-01-18 8:05 ` Thomas Huth
2017-01-18 9:52 ` Fam Zheng
0 siblings, 2 replies; 3+ messages in thread
From: Ziyue Yang @ 2017-01-18 8:03 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Fam Zheng, Thomas Huth, Paolo Bonzini, Anthony Liguori,
Ziyue Yang, Ziyue Yang
From: Ziyue Yang <yzylivezh@hotmail.com>
Some updates from fprintf(stderr, ...) to error_report.
Signed-off-by: Ziyue Yang <skiver.cloud.yzy@gmail.com>
---
gdbstub.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 426d55e..959f6dc 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu,
*p = s;
if (g_pos) {
if (g_pos != s->base_reg) {
- fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
- "Expected %d got %d\n", xml, g_pos, s->base_reg);
+ error_report("Error: Bad gdb register numbering for '%s', "
+ "expected %d got %d", xml, g_pos, s->base_reg);
} else {
cpu->gdb_num_g_regs = cpu->gdb_num_regs;
}
@@ -890,7 +890,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
}
case 'k':
/* Kill the target */
- fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
+ error_report("QEMU: Terminated via GDBstub");
exit(0);
case 'D':
/* Detach packet */
@@ -1358,8 +1358,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va)
break;
default:
bad_format:
- fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
- fmt - 1);
+ error_report("gdbstub: Bad syscall format string '%s'",
+ fmt - 1);
break;
}
} else {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements
2017-01-18 8:03 [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements Ziyue Yang
@ 2017-01-18 8:05 ` Thomas Huth
2017-01-18 9:52 ` Fam Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2017-01-18 8:05 UTC (permalink / raw)
To: Ziyue Yang, qemu-devel, qemu-trivial; +Cc: Fam Zheng, Paolo Bonzini, Ziyue Yang
On 18.01.2017 09:03, Ziyue Yang wrote:
> From: Ziyue Yang <yzylivezh@hotmail.com>
>
> Some updates from fprintf(stderr, ...) to error_report.
>
> Signed-off-by: Ziyue Yang <skiver.cloud.yzy@gmail.com>
> ---
> gdbstub.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 426d55e..959f6dc 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu,
> *p = s;
> if (g_pos) {
> if (g_pos != s->base_reg) {
> - fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
> - "Expected %d got %d\n", xml, g_pos, s->base_reg);
> + error_report("Error: Bad gdb register numbering for '%s', "
> + "expected %d got %d", xml, g_pos, s->base_reg);
> } else {
> cpu->gdb_num_g_regs = cpu->gdb_num_regs;
> }
> @@ -890,7 +890,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
> }
> case 'k':
> /* Kill the target */
> - fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
> + error_report("QEMU: Terminated via GDBstub");
> exit(0);
> case 'D':
> /* Detach packet */
> @@ -1358,8 +1358,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va)
> break;
> default:
> bad_format:
> - fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
> - fmt - 1);
> + error_report("gdbstub: Bad syscall format string '%s'",
> + fmt - 1);
> break;
> }
> } else {
> --
> 2.7.4
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements
2017-01-18 8:03 [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements Ziyue Yang
2017-01-18 8:05 ` Thomas Huth
@ 2017-01-18 9:52 ` Fam Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-01-18 9:52 UTC (permalink / raw)
To: Ziyue Yang; +Cc: qemu-devel, qemu-trivial, Ziyue Yang
On Wed, 01/18 16:03, Ziyue Yang wrote:
> From: Ziyue Yang <yzylivezh@hotmail.com>
>
> Some updates from fprintf(stderr, ...) to error_report.
In the future, please use "git format-patch --cover-letter" and "git send-email
--thread" to make sure the patches form a thread. See also:
http://wiki.qemu.org/Contribute/SubmitAPatch
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-18 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 8:03 [Qemu-trivial] [PATCH v5 2/2] gdbstub.c: update old error report statements Ziyue Yang
2017-01-18 8:05 ` Thomas Huth
2017-01-18 9:52 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).