From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dG3i1-00007I-Nv for mharc-qemu-trivial@gnu.org; Wed, 31 May 2017 09:30:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dG3hz-00005J-AN for qemu-trivial@nongnu.org; Wed, 31 May 2017 09:30:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dG3hv-0002LK-Uy for qemu-trivial@nongnu.org; Wed, 31 May 2017 09:30:43 -0400 Received: from 18.mo5.mail-out.ovh.net ([178.33.45.10]:34916) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dG3hv-0002KS-OX for qemu-trivial@nongnu.org; Wed, 31 May 2017 09:30:39 -0400 Received: from player799.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id EACF3FF967 for ; Wed, 31 May 2017 15:30:37 +0200 (CEST) Received: from bahia.lan (gar31-1-82-66-74-139.fbx.proxad.net [82.66.74.139]) (Authenticated sender: groug@kaod.org) by player799.ha.ovh.net (Postfix) with ESMTPSA id C486A520091; Wed, 31 May 2017 15:30:29 +0200 (CEST) Date: Wed, 31 May 2017 15:30:27 +0200 From: Greg Kurz To: Laurent Vivier Cc: Christian Borntraeger , Cornelia Huck , qemu-trivial@nongnu.org, Fam Zheng , qemu-devel@nongnu.org, Alexander Graf Message-ID: <20170531153027.6133baef@bahia.lan> In-Reply-To: <32546ddf-a725-5dd4-95cb-75a41da8e6ec@redhat.com> References: <149615665491.28067.17765793725374594694.stgit@bahia.lan> <20170530185618.2e875ebb@bahia.ttt.fr.ibm.com> <32546ddf-a725-5dd4-95cb-75a41da8e6ec@redhat.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/w6Qx23FL5Qi8A.0tYGi_Bgl"; protocol="application/pgp-signature" X-Ovh-Tracer-Id: 14230248924425328934 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeljedrgeeigdeijecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 178.33.45.10 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 13:30:44 -0000 --Sig_/w6Qx23FL5Qi8A.0tYGi_Bgl Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 31 May 2017 15:15:56 +0200 Laurent Vivier wrote: > On 30/05/2017 18:56, Greg Kurz wrote: > > On Tue, 30 May 2017 18:34:46 +0200 > > Christian Borntraeger wrote: > > =20 > >> On 05/30/2017 05:04 PM, Greg Kurz wrote: =20 > >>> The docker-run-test-build@debian-s390x-cross target fails with: > >>> > >>> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img > >>> strip: Unable to recognise the format of the input file `s390-ccw.elf' > >>> > >>> The configure script defines a STRIP makefile variable whose default > >>> value is ${cross_prefix}strip. Let's use it. > >>> > >>> Signed-off-by: Greg Kurz > >>> --- > >>> pc-bios/s390-ccw/Makefile | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile > >>> index 79a46b67356f..7af57dad109c 100644 > >>> --- a/pc-bios/s390-ccw/Makefile > >>> +++ b/pc-bios/s390-ccw/Makefile > >>> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS) > >>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(T= ARGET_DIR)$@") > >>> > >>> s390-ccw.img: s390-ccw.elf > >>> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TAR= GET_DIR)$@") > >>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(= TARGET_DIR)$@") > >>> > >>> $(OBJECTS): Makefile > >>> > >>> =20 > >> > >> I was going to apply this, but it fails with --disable-strip like > >> > >> /bin/sh: --strip-unneeded: command not found > >> Makefile:25: recipe for target 's390-ccw.img' failed > >> make[1]: *** [s390-ccw.img] Error 127 > >> Makefile:354: recipe for target 'romsubdir-s390-ccw' failed > >> make: *** [romsubdir-s390-ccw] Error 2 > >> > >> Not yet sure whats going on. > >> =20 > >=20 > > configure doesn't generate STRIP when --disable-strip or --enable-debug= ... so > > I guess we shouldn't use it here, but rather generate a s390_cross_pref= ix like > > in roms/Makefile ? > > =20 >=20 > I experimented the problem when I played with docker, and fixed the > problem as you did (with STRIP). >=20 I've sent a v2 with a 'STRIP ?=3D strip' line to handle the issue reported by Christian. > But I think it's a good idea to compile s390 rom as it is done for ppc64 > and ppc roms. >=20 Yeah, I was thinking about that too but I don't know all the ins and outs. > Laurent --Sig_/w6Qx23FL5Qi8A.0tYGi_Bgl Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlkuxXQACgkQAvw66wEB28K00wCfdjhi2dR+/3cR0iZQBmtlKBDB ND0Anjr+Q7vGgjXN5nOq2tHDPwEXAGur =Fbi9 -----END PGP SIGNATURE----- --Sig_/w6Qx23FL5Qi8A.0tYGi_Bgl--