From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alistair Francis" <alistair.francis@xilinx.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH for 2.10 02/35] loader: check get_image_size() return value
Date: Mon, 24 Jul 2017 15:27:18 -0300 [thread overview]
Message-ID: <20170724182751.18261-3-f4bug@amsat.org> (raw)
In-Reply-To: <20170724182751.18261-1-f4bug@amsat.org>
since a negative value means it errored.
hw/core/loader.c:149:9: warning: Loss of sign in implicit conversion
if (size > max_sz) {
^~~~
hw/core/loader.c:171:9: warning: Loss of sign in implicit conversion
if (size > memory_region_size(mr)) {
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/core/loader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index c17ace0a2e..4bb176f284 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -146,7 +146,7 @@ int load_image_targphys_as(const char *filename,
int size;
size = get_image_size(filename);
- if (size > max_sz) {
+ if (size < 0 || size > max_sz) {
return -1;
}
if (size > 0) {
@@ -168,7 +168,7 @@ int load_image_mr(const char *filename, MemoryRegion *mr)
size = get_image_size(filename);
- if (size > memory_region_size(mr)) {
+ if (size < 0 || size > memory_region_size(mr)) {
return -1;
}
if (size > 0) {
--
2.13.3
next prev parent reply other threads:[~2017-07-24 18:28 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 18:27 [Qemu-trivial] [PATCH for 2.10 00/35] fix bugs reported by Clang Static Analyzer Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 01/35] tests: add missing dependency to build QTEST_QEMU_BINARY Philippe Mathieu-Daudé
2017-07-24 18:27 ` Philippe Mathieu-Daudé [this message]
2017-07-24 18:38 ` [Qemu-trivial] [PATCH for 2.10 02/35] loader: check get_image_size() return value Eric Blake
2017-07-24 20:59 ` [Qemu-trivial] [Qemu-devel] " Alistair Francis
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 03/35] thunk: check nb_fields is valid before continuing Philippe Mathieu-Daudé
2017-07-24 18:37 ` Eric Blake
2017-07-26 22:48 ` Philippe Mathieu-Daudé
2017-07-24 21:16 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 05/35] nbd: fix memory leak in nbd_opt_go() Philippe Mathieu-Daudé
2017-07-24 18:41 ` Eric Blake
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 06/35] qcow2: remove inconsistent check Philippe Mathieu-Daudé
2017-07-24 18:42 ` Eric Blake
2017-07-25 15:36 ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 07/35] qcow2: fix null pointer dereference Philippe Mathieu-Daudé
2017-07-24 18:46 ` Eric Blake
2017-07-25 1:44 ` Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 08/35] " Philippe Mathieu-Daudé
2017-07-24 18:52 ` Eric Blake
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 09/35] ui/vnc: fix leak of SocketAddress ** Philippe Mathieu-Daudé
2017-07-25 8:37 ` [Qemu-trivial] [Qemu-devel] " Daniel P. Berrange
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 10/35] net/eth: fix incorrect check of iov_to_buf() return value Philippe Mathieu-Daudé
2017-07-26 9:51 ` Dmitry Fleytman
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 12/35] vfio/platform: fix use of freed memory Philippe Mathieu-Daudé
2017-07-25 15:37 ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2017-07-26 17:43 ` [Qemu-trivial] " Alex Williamson
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 13/35] vfio/pci: " Philippe Mathieu-Daudé
2017-07-25 15:38 ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 14/35] vfio/ccw: fix incorrect malloc() size Philippe Mathieu-Daudé
2017-07-25 7:20 ` Cornelia Huck
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 15/35] usb: correctly handle Zero Length Packets Philippe Mathieu-Daudé
2018-05-29 14:22 ` Philippe Mathieu-Daudé
2018-05-30 6:16 ` Gerd Hoffmann
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 19/35] usb/dev-mtp: fix use of uninitialized variable Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 20/35] arm/boot: fix undefined instruction on secondary smp cpu bootloader Philippe Mathieu-Daudé
2017-07-24 21:06 ` Peter Maydell
2017-07-26 23:00 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 22/35] arm/vexpress: fix potential memory leak Philippe Mathieu-Daudé
2017-07-24 21:11 ` Peter Maydell
2017-07-24 21:45 ` Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste Philippe Mathieu-Daudé
2017-07-24 18:54 ` Laurent Vivier
2017-07-24 19:01 ` Richard Henderson
2017-07-24 19:19 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-24 19:20 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write Philippe Mathieu-Daudé
2017-07-24 18:59 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 25/35] linux-user: extract is_error() out of syscall.c Philippe Mathieu-Daudé
2017-07-24 19:14 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer Philippe Mathieu-Daudé
2017-07-24 19:16 ` Laurent Vivier
2018-05-29 14:25 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2018-05-29 15:19 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 27/35] syscall: fix dereference of undefined pointer Philippe Mathieu-Daudé
2017-07-24 19:33 ` Laurent Vivier
2017-07-25 5:34 ` Philippe Mathieu-Daudé
2017-07-24 21:26 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2017-07-25 7:25 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 29/35] syscall: fix out-of-bound memory access Philippe Mathieu-Daudé
2017-07-24 19:41 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 30/35] syscall: fix use of uninitialized values Philippe Mathieu-Daudé
2017-07-24 19:51 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 31/35] syscall: replace strcpy() by g_strlcpy() Philippe Mathieu-Daudé
2017-07-24 19:28 ` Laurent Vivier
2018-05-29 14:19 ` Philippe Mathieu-Daudé
2018-05-29 15:22 ` Laurent Vivier
2017-07-24 18:27 ` [Qemu-trivial] [PATCH for 2.10 32/35] timer/pxa2xx: silent warning about out-of-bound memory access Philippe Mathieu-Daudé
2017-07-24 21:01 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2017-07-24 21:51 ` Philippe Mathieu-Daudé
2017-07-24 18:27 ` [Qemu-trivial] [RFC PATCH for 2.10 35/35] script to run docker image Philippe Mathieu-Daudé
2017-07-25 14:12 ` Alex Bennée
2017-07-25 14:41 ` Philippe Mathieu-Daudé
2017-07-25 15:03 ` Alex Bennée
2017-07-25 15:17 ` Philippe Mathieu-Daudé
2017-07-24 21:27 ` [Qemu-trivial] [PATCH for 2.10 00/35] fix bugs reported by Clang Static Analyzer Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724182751.18261-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@xilinx.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).