From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1db49e-0000w2-0R for mharc-qemu-trivial@gnu.org; Fri, 28 Jul 2017 08:14:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1db49b-0000oO-D1 for qemu-trivial@nongnu.org; Fri, 28 Jul 2017 08:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1db49a-0005sD-BM for qemu-trivial@nongnu.org; Fri, 28 Jul 2017 08:14:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53736) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1db49V-0005kp-VA; Fri, 28 Jul 2017 08:13:58 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CABE7C007988; Fri, 28 Jul 2017 12:13:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CABE7C007988 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=cohuck@redhat.com Received: from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id D55FE5C8AE; Fri, 28 Jul 2017 12:13:55 +0000 (UTC) Date: Fri, 28 Jul 2017 14:13:53 +0200 From: Cornelia Huck To: Paolo Bonzini Cc: Thomas Huth , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , qemu-trivial@nongnu.org, qemu-devel@nongnu.org Message-ID: <20170728141353.3b8382be@gondolin> In-Reply-To: <3abbfa87-d882-39ab-b4ab-66f3e68a2fb4@redhat.com> References: <20170728053610.15770-1-f4bug@amsat.org> <20170728053610.15770-6-f4bug@amsat.org> <20170728135614.3f14e3ad@gondolin> <3abbfa87-d882-39ab-b4ab-66f3e68a2fb4@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 28 Jul 2017 12:13:56 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2017 12:14:04 -0000 On Fri, 28 Jul 2017 13:59:08 +0200 Paolo Bonzini wrote: > On 28/07/2017 13:56, Cornelia Huck wrote: > > On Fri, 28 Jul 2017 13:51:14 +0200 > > Paolo Bonzini wrote: > > =20 > >> On 28/07/2017 09:00, Thomas Huth wrote: =20 > >>> On 28.07.2017 07:35, Philippe Mathieu-Daud=C3=A9 wrote: =20 > >>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >>>> --- > >>>> MAINTAINERS | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>> index 3b472d7a09..ece02522be 100644 > >>>> --- a/MAINTAINERS > >>>> +++ b/MAINTAINERS > >>>> @@ -278,6 +278,7 @@ S: Supported > >>>> F: */kvm.* > >>>> F: accel/kvm/ > >>>> F: include/sysemu/kvm*.h > >>>> +F: linux-headers/asm-*/kvm*.h =20 > >>> > >>> The linux-headers are not really maintained by the QEMU project - so I > >>> guess we do not need an entry for these? =20 > >> > >> Actually I agree with the patch. I'd like to be CCed on > >> update-linux-headers patches, and this achieves it. :) =20 > >=20 > > But would it not a better idea to add an entry for all headers touched > > by update-linux-headers, then? =20 >=20 > One thing doesn't exclude the other. That entry would also list the > script itself and linux-headers. KVM, VFIO and virtio patterns can only > list the files they care about. Migration could list userfaultfd, > possibly. And there's also include/standard-headers/, which includes > PCI and input subsystem files... It has to be perfected, but it's a > good idea. Personally, I'm not really a fan. If something is changed in one of the headers, it implies that either it has already been changed in the original headers in Linux (and I will have seen it then), or that someone is sending a preliminary patch (and I should hope that I'm already cc:ed for the changes that this headers change is for then). It does not really hurt, but it feels wrong.