From: Eduardo Otubo <otubo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Jarno, Aurelien" <aurelien@aurel32.net>,
Eduardo Habkost <ehabkost@redhat.com>,
mst@redhat.com, qemu-trivial@nongnu.org,
Alexander Graf <agraf@suse.de>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-ppc@nongnu.org, "Gibson,
David" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
Date: Fri, 8 Sep 2017 09:57:05 +0200 [thread overview]
Message-ID: <20170908075705.GA16888@vader> (raw)
In-Reply-To: <CABgObfZ-CthwUFC-E2QTxnpqYZ-Sr_f_M3-FdmH6tQPdjG3OAg@mail.gmail.com>
On Thu, Sep 07, 2017 at 06:05:37PM +0200, Paolo Bonzini wrote:
> Il 02 set 2017 11:17 AM, "Aurelien Jarno" <aurelien@aurel32.net> ha scritto:
>
> On 2017-09-01 11:30, Eduardo Habkost wrote:
> > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > maintainers for those architectures.
>
> The i82374 device is not useful nor usable on SH4. It has just been
> added in commit 85d3846a39 to be able to run the tests.
>
>
> But that means that the patch is wrong and probably was not tested with
> "make check".
>
> Eduardo's proposal is the right one.
>
Great, I'll just add the missing details and resend the v2. Thanks for
the review.
Regards,
--
Eduardo Otubo
Senior Software Engineer @ RedHat
prev parent reply other threads:[~2017-09-08 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 11:03 [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device Eduardo Otubo
2017-09-01 14:30 ` Eduardo Habkost
2017-09-01 15:34 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-09-01 15:44 ` Eduardo Habkost
2017-09-07 8:38 ` Eduardo Otubo
2017-09-09 21:52 ` Eduardo Habkost
2017-09-02 9:15 ` [Qemu-trivial] " Aurelien Jarno
2017-09-07 8:38 ` Eduardo Otubo
2017-09-07 16:05 ` [Qemu-trivial] [Qemu-devel] " Paolo Bonzini
2017-09-08 7:57 ` Eduardo Otubo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908075705.GA16888@vader \
--to=otubo@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).