qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH v3 31/42] hw/timer/i8254: rename pit_init() -> i8254_pit_init()
Date: Tue, 17 Oct 2017 13:44:15 -0300	[thread overview]
Message-ID: <20171017164426.25277-32-f4bug@amsat.org> (raw)
In-Reply-To: <20171017164426.25277-1-f4bug@amsat.org>

and remove the old i386/pc dependency

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
---
 include/hw/timer/i8254.h          | 5 +++--
 include/hw/timer/i8254_internal.h | 2 +-
 hw/alpha/dp264.c                  | 2 +-
 hw/i386/pc.c                      | 2 +-
 hw/isa/i82378.c                   | 2 +-
 hw/mips/mips_fulong2e.c           | 2 +-
 hw/mips/mips_jazz.c               | 2 +-
 hw/mips/mips_malta.c              | 2 +-
 hw/mips/mips_r4k.c                | 2 +-
 hw/timer/i8254.c                  | 1 -
 hw/timer/i8254_common.c           | 1 -
 11 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/include/hw/timer/i8254.h b/include/hw/timer/i8254.h
index 5adae9fa44..5b12eb918e 100644
--- a/include/hw/timer/i8254.h
+++ b/include/hw/timer/i8254.h
@@ -26,6 +26,7 @@
 #define HW_I8254_H
 
 #include "hw/hw.h"
+#include "hw/qdev.h"
 #include "hw/isa/isa.h"
 
 #define PIT_FREQ 1193182
@@ -48,8 +49,8 @@ typedef struct PITChannelInfo {
 #define TYPE_I8254 "isa-pit"
 #define TYPE_KVM_I8254 "kvm-pit"
 
-static inline ISADevice *pit_init(ISABus *bus, int base, int isa_irq,
-                                  qemu_irq alt_irq)
+static inline ISADevice *i8254_pit_init(ISABus *bus, int base, int isa_irq,
+                                        qemu_irq alt_irq)
 {
     DeviceState *dev;
     ISADevice *d;
diff --git a/include/hw/timer/i8254_internal.h b/include/hw/timer/i8254_internal.h
index dc09cc0467..c37a438f82 100644
--- a/include/hw/timer/i8254_internal.h
+++ b/include/hw/timer/i8254_internal.h
@@ -26,8 +26,8 @@
 #define QEMU_I8254_INTERNAL_H
 
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
 #include "hw/isa/isa.h"
+#include "qemu/timer.h"
 
 typedef struct PITChannelState {
     int count; /* can be 65536 */
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index 1b121306c2..1bd5243648 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -81,7 +81,7 @@ static void clipper_init(MachineState *machine)
     /* Since we have an SRM-compatible PALcode, use the SRM epoch.  */
     rtc_init(isa_bus, 1900, rtc_irq);
 
-    pit_init(isa_bus, 0x40, 0, NULL);
+    i8254_pit_init(isa_bus, 0x40, 0, NULL);
     isa_create_simple(isa_bus, "i8042");
 
     /* VGA setup.  Don't bother loading the bios.  */
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 05985d4927..b565c6086c 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1551,7 +1551,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
         if (kvm_pit_in_kernel()) {
             pit = kvm_pit_init(isa_bus, 0x40);
         } else {
-            pit = pit_init(isa_bus, 0x40, pit_isa_irq, pit_alt_irq);
+            pit = i8254_pit_init(isa_bus, 0x40, pit_isa_irq, pit_alt_irq);
         }
         if (hpet) {
             /* connect PIT to output control line of the HPET */
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index d20ea4c2ee..a9c15f858d 100644
--- a/hw/isa/i82378.c
+++ b/hw/isa/i82378.c
@@ -97,7 +97,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp)
     isa_bus_irqs(isabus, s->i8259);
 
     /* 1 82C54 (pit) */
-    isa = pit_init(isabus, 0x40, 0, NULL);
+    isa = i8254_pit_init(isabus, 0x40, 0, NULL);
 
     /* speaker */
     pcspk_init(isabus, isa);
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 75318680e1..22e6c05fb5 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -363,7 +363,7 @@ static void mips_fulong2e_init(MachineState *machine)
     smbus_eeprom_init(smbus, 1, eeprom_spd, sizeof(eeprom_spd));
 
     /* init other devices */
-    pit = pit_init(isa_bus, 0x40, 0, NULL);
+    pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
     DMA_init(isa_bus, 0);
 
     /* Super I/O */
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index 7e6626dc88..5f37852499 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -222,7 +222,7 @@ static void mips_jazz_init(MachineState *machine,
     i8259 = i8259_init(isa_bus, env->irq[4]);
     isa_bus_irqs(isa_bus, i8259);
     DMA_init(isa_bus, 0);
-    pit = pit_init(isa_bus, 0x40, 0, NULL);
+    pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
     pcspk_init(isa_bus, pit);
 
     /* Video card */
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 2adb9bcf89..de547d732f 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1217,7 +1217,7 @@ void mips_malta_init(MachineState *machine)
                           isa_get_irq(NULL, 9), NULL, 0, NULL);
     smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);
     g_free(smbus_eeprom_buf);
-    pit = pit_init(isa_bus, 0x40, 0, NULL);
+    pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
     DMA_init(isa_bus, 0);
 
     /* Super I/O */
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 1272d4ef9d..48fad52540 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -280,7 +280,7 @@ void mips_r4k_init(MachineState *machine)
 
     rtc_init(isa_bus, 2000, NULL);
 
-    pit = pit_init(isa_bus, 0x40, 0, NULL);
+    pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
 
     serial_hds_isa_init(isa_bus, 0, MAX_SERIAL_PORTS);
 
diff --git a/hw/timer/i8254.c b/hw/timer/i8254.c
index 5e61ad50a8..dbc4a0baec 100644
--- a/hw/timer/i8254.c
+++ b/hw/timer/i8254.c
@@ -23,7 +23,6 @@
  */
 #include "qemu/osdep.h"
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
 #include "hw/isa/isa.h"
 #include "qemu/timer.h"
 #include "hw/timer/i8254.h"
diff --git a/hw/timer/i8254_common.c b/hw/timer/i8254_common.c
index b623c96198..6190b6fc5d 100644
--- a/hw/timer/i8254_common.c
+++ b/hw/timer/i8254_common.c
@@ -24,7 +24,6 @@
  */
 #include "qemu/osdep.h"
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
 #include "hw/isa/isa.h"
 #include "qemu/timer.h"
 #include "hw/timer/i8254.h"
-- 
2.15.0.rc0



  parent reply	other threads:[~2017-10-17 16:46 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 16:43 [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 01/42] MAINTAINERS: add entries for i2c/ppc4xx Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 02/42] MAINTAINERS: add an entry for the i82374 (southbridge) Philippe Mathieu-Daudé
2017-10-18 12:04   ` Thomas Huth
2017-11-06 21:41   ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 03/42] MAINTAINERS: add an entry for the i8257 (DMA controller) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 04/42] MAINTAINERS: add an entry for the i82378 (superio) Philippe Mathieu-Daudé
2017-11-06 22:12   ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 05/42] MAINTAINERS: add an entry for watchdog/wdt_ib700 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 06/42] MAINTAINERS: add an entry for input/pckbd.c Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 07/42] MAINTAINERS: add entries for timer/m48t59 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 08/42] MAINTAINERS: add missing entry for include/hw/net/ Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 09/42] hw: use "qemu/osdep.h" as first #include in source files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 10/42] hw: remove "qemu/osdep.h" from header files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 11/42] block: remove "qemu/osdep.h" from header file Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 12/42] misc: remove headers implicitly included Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 13/42] misc: remove duplicated includes Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 14/42] ppc: " Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 15/42] i386/hax: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 16/42] i386/hax: remove duplicated include Philippe Mathieu-Daudé
2017-10-18 12:12   ` Thomas Huth
2017-10-18 12:18     ` Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 17/42] nios2: remove duplicated includes (in code commented out) Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 18/42] misc: avoid "include/" in include path Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 19/42] numa: remove unused #include Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 20/42] hw/input/vmmouse: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 21/42] hw/misc/pvpanic: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 22/42] hw/ssi/aspeed_smc: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 23/42] amd_iommu: avoid needless includes in header file Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 24/42] misc: remove old i386 dependency Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 25/42] hw/ide: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 26/42] hw/ipmi: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 27/42] hw/i2c: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 28/42] hw/tpm: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 29/42] hw/virtio-balloon: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 30/42] hw/unicore32: restrict hw addr defines to source file Philippe Mathieu-Daudé
2017-10-17 16:44 ` Philippe Mathieu-Daudé [this message]
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 32/42] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init() Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch Philippe Mathieu-Daudé
2017-10-18  7:44   ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc Philippe Mathieu-Daudé
2017-10-18  7:45   ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 35/42] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h" Philippe Mathieu-Daudé
2017-10-18 12:26   ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 36/42] hw/display/vga: "vga_int.h" requires "ui/console.h" Philippe Mathieu-Daudé
2017-10-18 12:14   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 37/42] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h" Philippe Mathieu-Daudé
2017-10-18 12:19   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 38/42] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 39/42] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h" Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 40/42] i386/pc: move vmport.c to hw/i386/ Philippe Mathieu-Daudé
2017-10-18 12:47   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 41/42] i386/pc: move vmmouse.c " Philippe Mathieu-Daudé
2017-10-18 12:49   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 42/42] misc: drop old i386 dependency Philippe Mathieu-Daudé
2017-11-06 19:02 ` [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-11-08 16:56 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017164426.25277-32-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).