qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Yongbok Kim" <yongbok.kim@imgtec.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH v3 37/42] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h"
Date: Tue, 17 Oct 2017 13:44:21 -0300	[thread overview]
Message-ID: <20171017164426.25277-38-f4bug@amsat.org> (raw)
In-Reply-To: <20171017164426.25277-1-f4bug@amsat.org>

and remove the old i386/pc dependency.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 include/hw/display/vga.h | 25 +++++++++++++++++++++++++
 include/hw/i386/pc.h     | 12 ------------
 hw/display/vga-isa-mm.c  |  3 +--
 hw/display/vga-isa.c     |  2 +-
 hw/display/vga.c         |  2 +-
 hw/mips/mips_jazz.c      |  1 +
 vl.c                     |  2 +-
 MAINTAINERS              |  1 +
 8 files changed, 31 insertions(+), 17 deletions(-)
 create mode 100644 include/hw/display/vga.h

diff --git a/include/hw/display/vga.h b/include/hw/display/vga.h
new file mode 100644
index 0000000000..0401a3a292
--- /dev/null
+++ b/include/hw/display/vga.h
@@ -0,0 +1,25 @@
+/*
+ * QEMU VGA Emulator.
+ *
+ * Copyright (c) 2003 Fabrice Bellard
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+#ifndef QEMU_HW_DISPLAY_VGA_H
+#define QEMU_HW_DISPLAY_VGA_H
+
+#include "exec/memory.h"
+
+enum vga_retrace_method {
+    VGA_RETRACE_DUMB,
+    VGA_RETRACE_PRECISE
+};
+
+extern enum vga_retrace_method vga_retrace_method;
+
+int isa_vga_mm_init(hwaddr vram_base,
+                    hwaddr ctrl_base, int it_shift,
+                    MemoryRegion *address_space);
+
+#endif
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index b1b4c918af..25ba378bd8 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -302,18 +302,6 @@ PCIBus *find_i440fx(void);
 extern PCIDevice *piix4_dev;
 int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn);
 
-/* vga.c */
-enum vga_retrace_method {
-    VGA_RETRACE_DUMB,
-    VGA_RETRACE_PRECISE
-};
-
-extern enum vga_retrace_method vga_retrace_method;
-
-int isa_vga_mm_init(hwaddr vram_base,
-                    hwaddr ctrl_base, int it_shift,
-                    MemoryRegion *address_space);
-
 /* ne2000.c */
 static inline bool isa_ne2000_init(ISABus *bus, int base, int irq, NICInfo *nd)
 {
diff --git a/hw/display/vga-isa-mm.c b/hw/display/vga-isa-mm.c
index 68c4d6e23e..e887b45651 100644
--- a/hw/display/vga-isa-mm.c
+++ b/hw/display/vga-isa-mm.c
@@ -23,10 +23,9 @@
  */
 #include "qemu/osdep.h"
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
+#include "hw/display/vga.h"
 #include "vga_int.h"
 #include "ui/pixel_ops.h"
-#include "qemu/timer.h"
 
 #define VGA_RAM_SIZE (8192 * 1024)
 
diff --git a/hw/display/vga-isa.c b/hw/display/vga-isa.c
index 26f69fd40a..469834add5 100644
--- a/hw/display/vga-isa.c
+++ b/hw/display/vga-isa.c
@@ -25,7 +25,7 @@
  */
 #include "qemu/osdep.h"
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
+#include "hw/isa/isa.h"
 #include "vga_int.h"
 #include "ui/pixel_ops.h"
 #include "qemu/timer.h"
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 22fd069ad2..59729f7031 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -24,7 +24,7 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
-#include "hw/i386/pc.h"
+#include "hw/display/vga.h"
 #include "hw/pci/pci.h"
 #include "vga_int.h"
 #include "vga_regs.h"
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index b9ffb33b45..ece4a153b2 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -39,6 +39,7 @@
 #include "hw/loader.h"
 #include "hw/timer/mc146818rtc.h"
 #include "hw/timer/i8254.h"
+#include "hw/display/vga.h"
 #include "hw/audio/pcspk.h"
 #include "sysemu/block-backend.h"
 #include "hw/sysbus.h"
diff --git a/vl.c b/vl.c
index 0d1f612629..f0b7106feb 100644
--- a/vl.c
+++ b/vl.c
@@ -57,9 +57,9 @@ int main(int argc, char **argv)
 #include "hw/boards.h"
 #include "sysemu/accel.h"
 #include "hw/usb.h"
-#include "hw/i386/pc.h"
 #include "hw/isa/isa.h"
 #include "hw/scsi/scsi.h"
+#include "hw/display/vga.h"
 #include "hw/bt.h"
 #include "sysemu/watchdog.h"
 #include "hw/smbios/smbios.h"
diff --git a/MAINTAINERS b/MAINTAINERS
index 0e926a942b..81b67e4685 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -860,6 +860,7 @@ F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
 F: hw/watchdog/wdt_ib700.c
+F: include/hw/display/vga.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/isa/i8257.h
 F: include/hw/timer/hpet.h
-- 
2.15.0.rc0



  parent reply	other threads:[~2017-10-17 16:47 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 16:43 [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 01/42] MAINTAINERS: add entries for i2c/ppc4xx Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 02/42] MAINTAINERS: add an entry for the i82374 (southbridge) Philippe Mathieu-Daudé
2017-10-18 12:04   ` Thomas Huth
2017-11-06 21:41   ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 03/42] MAINTAINERS: add an entry for the i8257 (DMA controller) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 04/42] MAINTAINERS: add an entry for the i82378 (superio) Philippe Mathieu-Daudé
2017-11-06 22:12   ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 05/42] MAINTAINERS: add an entry for watchdog/wdt_ib700 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 06/42] MAINTAINERS: add an entry for input/pckbd.c Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 07/42] MAINTAINERS: add entries for timer/m48t59 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 08/42] MAINTAINERS: add missing entry for include/hw/net/ Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 09/42] hw: use "qemu/osdep.h" as first #include in source files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 10/42] hw: remove "qemu/osdep.h" from header files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 11/42] block: remove "qemu/osdep.h" from header file Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 12/42] misc: remove headers implicitly included Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 13/42] misc: remove duplicated includes Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 14/42] ppc: " Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 15/42] i386/hax: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 16/42] i386/hax: remove duplicated include Philippe Mathieu-Daudé
2017-10-18 12:12   ` Thomas Huth
2017-10-18 12:18     ` Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 17/42] nios2: remove duplicated includes (in code commented out) Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 18/42] misc: avoid "include/" in include path Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 19/42] numa: remove unused #include Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 20/42] hw/input/vmmouse: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 21/42] hw/misc/pvpanic: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 22/42] hw/ssi/aspeed_smc: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 23/42] amd_iommu: avoid needless includes in header file Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 24/42] misc: remove old i386 dependency Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 25/42] hw/ide: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 26/42] hw/ipmi: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 27/42] hw/i2c: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 28/42] hw/tpm: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 29/42] hw/virtio-balloon: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 30/42] hw/unicore32: restrict hw addr defines to source file Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 31/42] hw/timer/i8254: rename pit_init() -> i8254_pit_init() Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 32/42] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init() Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch Philippe Mathieu-Daudé
2017-10-18  7:44   ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc Philippe Mathieu-Daudé
2017-10-18  7:45   ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 35/42] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h" Philippe Mathieu-Daudé
2017-10-18 12:26   ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 36/42] hw/display/vga: "vga_int.h" requires "ui/console.h" Philippe Mathieu-Daudé
2017-10-18 12:14   ` Thomas Huth
2017-10-17 16:44 ` Philippe Mathieu-Daudé [this message]
2017-10-18 12:19   ` [Qemu-trivial] [PATCH v3 37/42] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h" Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 38/42] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 39/42] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h" Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 40/42] i386/pc: move vmport.c to hw/i386/ Philippe Mathieu-Daudé
2017-10-18 12:47   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 41/42] i386/pc: move vmmouse.c " Philippe Mathieu-Daudé
2017-10-18 12:49   ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 42/42] misc: drop old i386 dependency Philippe Mathieu-Daudé
2017-11-06 19:02 ` [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-11-08 16:56 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017164426.25277-38-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aurelien@aurel32.net \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=kraxel@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=yongbok.kim@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).