From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH v3 39/42] hw/misc/pvpanic: extract public API from i386/pc to "hw/misc/pvpanic.h"
Date: Tue, 17 Oct 2017 13:44:23 -0300 [thread overview]
Message-ID: <20171017164426.25277-40-f4bug@amsat.org> (raw)
In-Reply-To: <20171017164426.25277-1-f4bug@amsat.org>
and remove the old i386/pc dependency.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
no MAINTAINERS entry, does this belong to "PC Chipset"?
include/hw/i386/pc.h | 3 ---
include/hw/misc/pvpanic.h | 21 +++++++++++++++++++++
hw/i386/acpi-build.c | 2 +-
hw/misc/pvpanic.c | 9 ++++-----
4 files changed, 26 insertions(+), 9 deletions(-)
create mode 100644 include/hw/misc/pvpanic.h
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 846d37b9fb..1a74ccd73b 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -306,9 +306,6 @@ int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn);
void pc_system_firmware_init(MemoryRegion *rom_memory,
bool isapc_ram_fw);
-/* pvpanic.c */
-uint16_t pvpanic_port(void);
-
/* acpi-build.c */
void pc_madt_cpu_entry(AcpiDeviceIf *adev, int uid,
const CPUArchIdList *apic_ids, GArray *entry);
diff --git a/include/hw/misc/pvpanic.h b/include/hw/misc/pvpanic.h
new file mode 100644
index 0000000000..36a54e270c
--- /dev/null
+++ b/include/hw/misc/pvpanic.h
@@ -0,0 +1,21 @@
+/*
+ * QEMU simulated pvpanic device.
+ *
+ * Copyright Fujitsu, Corp. 2013
+ *
+ * Authors:
+ * Wen Congyang <wency@cn.fujitsu.com>
+ * Hu Tao <hutao@cn.fujitsu.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+#ifndef HW_MISC_PVPANIC_H
+#define HW_MISC_PVPANIC_H
+
+#define TYPE_PVPANIC "pvpanic"
+
+uint16_t pvpanic_port(void);
+
+#endif
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 73519ab3ac..63bbc610eb 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -28,8 +28,8 @@
#include "qemu/error-report.h"
#include "hw/pci/pci.h"
#include "qom/cpu.h"
-#include "hw/i386/pc.h"
#include "target/i386/cpu.h"
+#include "hw/misc/pvpanic.h"
#include "hw/timer/hpet.h"
#include "hw/acpi/acpi-defs.h"
#include "hw/acpi/acpi.h"
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 3a0e4ba828..b26250dec9 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -17,7 +17,7 @@
#include "qemu/log.h"
#include "hw/nvram/fw_cfg.h"
-#include "hw/i386/pc.h"
+#include "hw/misc/pvpanic.h"
/* The bit of supported pv event */
#define PVPANIC_F_PANICKED 0
@@ -25,9 +25,8 @@
/* The pv event value */
#define PVPANIC_PANICKED (1 << PVPANIC_F_PANICKED)
-#define TYPE_ISA_PVPANIC_DEVICE "pvpanic"
#define ISA_PVPANIC_DEVICE(obj) \
- OBJECT_CHECK(PVPanicState, (obj), TYPE_ISA_PVPANIC_DEVICE)
+ OBJECT_CHECK(PVPanicState, (obj), TYPE_PVPANIC)
static void handle_event(int event)
{
@@ -104,7 +103,7 @@ static void pvpanic_isa_realizefn(DeviceState *dev, Error **errp)
uint16_t pvpanic_port(void)
{
- Object *o = object_resolve_path_type("", TYPE_ISA_PVPANIC_DEVICE, NULL);
+ Object *o = object_resolve_path_type("", TYPE_PVPANIC, NULL);
if (!o) {
return 0;
}
@@ -126,7 +125,7 @@ static void pvpanic_isa_class_init(ObjectClass *klass, void *data)
}
static TypeInfo pvpanic_isa_info = {
- .name = TYPE_ISA_PVPANIC_DEVICE,
+ .name = TYPE_PVPANIC,
.parent = TYPE_ISA_DEVICE,
.instance_size = sizeof(PVPanicState),
.instance_init = pvpanic_isa_initfn,
--
2.15.0.rc0
next prev parent reply other threads:[~2017-10-17 16:47 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 16:43 [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 01/42] MAINTAINERS: add entries for i2c/ppc4xx Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 02/42] MAINTAINERS: add an entry for the i82374 (southbridge) Philippe Mathieu-Daudé
2017-10-18 12:04 ` Thomas Huth
2017-11-06 21:41 ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 03/42] MAINTAINERS: add an entry for the i8257 (DMA controller) Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 04/42] MAINTAINERS: add an entry for the i82378 (superio) Philippe Mathieu-Daudé
2017-11-06 22:12 ` Hervé Poussineau
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 05/42] MAINTAINERS: add an entry for watchdog/wdt_ib700 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 06/42] MAINTAINERS: add an entry for input/pckbd.c Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 07/42] MAINTAINERS: add entries for timer/m48t59 Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 08/42] MAINTAINERS: add missing entry for include/hw/net/ Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 09/42] hw: use "qemu/osdep.h" as first #include in source files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 10/42] hw: remove "qemu/osdep.h" from header files Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 11/42] block: remove "qemu/osdep.h" from header file Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 12/42] misc: remove headers implicitly included Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 13/42] misc: remove duplicated includes Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 14/42] ppc: " Philippe Mathieu-Daudé
2017-10-17 16:43 ` [Qemu-trivial] [PATCH v3 15/42] i386/hax: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 16/42] i386/hax: remove duplicated include Philippe Mathieu-Daudé
2017-10-18 12:12 ` Thomas Huth
2017-10-18 12:18 ` Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 17/42] nios2: remove duplicated includes (in code commented out) Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 18/42] misc: avoid "include/" in include path Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 19/42] numa: remove unused #include Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 20/42] hw/input/vmmouse: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 21/42] hw/misc/pvpanic: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 22/42] hw/ssi/aspeed_smc: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 23/42] amd_iommu: avoid needless includes in header file Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 24/42] misc: remove old i386 dependency Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 25/42] hw/ide: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 26/42] hw/ipmi: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 27/42] hw/i2c: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 28/42] hw/tpm: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 29/42] hw/virtio-balloon: " Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 30/42] hw/unicore32: restrict hw addr defines to source file Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 31/42] hw/timer/i8254: rename pit_init() -> i8254_pit_init() Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 32/42] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init() Philippe Mathieu-Daudé
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch Philippe Mathieu-Daudé
2017-10-18 7:44 ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc Philippe Mathieu-Daudé
2017-10-18 7:45 ` Igor Mammedov
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 35/42] hw/display/vga: "vga.h" only contains registers defs, rename it "vga_regs.h" Philippe Mathieu-Daudé
2017-10-18 12:26 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 36/42] hw/display/vga: "vga_int.h" requires "ui/console.h" Philippe Mathieu-Daudé
2017-10-18 12:14 ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 37/42] hw/display/vga: extract public API from i386/pc to "hw/display/vga.h" Philippe Mathieu-Daudé
2017-10-18 12:19 ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 38/42] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c Philippe Mathieu-Daudé
2017-10-17 16:44 ` Philippe Mathieu-Daudé [this message]
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 40/42] i386/pc: move vmport.c to hw/i386/ Philippe Mathieu-Daudé
2017-10-18 12:47 ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 41/42] i386/pc: move vmmouse.c " Philippe Mathieu-Daudé
2017-10-18 12:49 ` Thomas Huth
2017-10-17 16:44 ` [Qemu-trivial] [PATCH v3 42/42] misc: drop old i386 dependency Philippe Mathieu-Daudé
2017-11-06 19:02 ` [Qemu-trivial] [PATCH v3 00/42] remove i386/pc dependency from non-PC world (part 1) Philippe Mathieu-Daudé
2017-11-08 16:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017164426.25277-40-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=ehabkost@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).