From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1efABB-0004c0-KA for mharc-qemu-trivial@gnu.org; Fri, 26 Jan 2018 15:00:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efAB9-0004aF-5S for qemu-trivial@nongnu.org; Fri, 26 Jan 2018 15:00:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efAB8-0003Qr-Al for qemu-trivial@nongnu.org; Fri, 26 Jan 2018 15:00:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59694) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1efAB1-0003Mm-VL; Fri, 26 Jan 2018 15:00:44 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAB45C0ADB59; Fri, 26 Jan 2018 20:00:42 +0000 (UTC) Received: from work-vm (ovpn-116-249.ams2.redhat.com [10.36.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 913FA5EE0E; Fri, 26 Jan 2018 20:00:38 +0000 (UTC) Date: Fri, 26 Jan 2018 20:00:35 +0000 From: "Dr. David Alan Gilbert" To: Paolo Bonzini Cc: Thomas Huth , qemu-devel@nongnu.org, Markus Armbruster , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-trivial@nongnu.org, "Daniel P. Berrange" Message-ID: <20180126200035.GJ2610@work-vm> References: <1513700253-10045-1-git-send-email-thuth@redhat.com> <20180122193504.GB2628@work-vm> <7495eb49-ed1e-2dbb-866e-c65b7e4147a8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7495eb49-ed1e-2dbb-866e-c65b7e4147a8@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 26 Jan 2018 20:00:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [PATCH] monitor: Remove legacy "-mon default=on" parameter X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 20:00:52 -0000 * Paolo Bonzini (pbonzini@redhat.com) wrote: > On 22/01/2018 20:35, Dr. David Alan Gilbert wrote: > > * Thomas Huth (thuth@redhat.com) wrote: > >> The "default" parameter of the "-mon" option is useless since > >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That > >> should have been long enough to let people update their scripts, > >> so time to remove it now. > >> > >> Signed-off-by: Thomas Huth > > > > Seems reasonable. > > > > > > Reviewed-by: Dr. David Alan Gilbert > > Are you also queuing it yourself? Yes I will do; I was just watching out for another HMP patch or two so it doesn't feel lonely. Dave > Thanks, > > Paolo > > >> --- > >> monitor.c | 3 --- > >> qemu-doc.texi | 9 --------- > >> vl.c | 4 ---- > >> 3 files changed, 16 deletions(-) > >> > >> diff --git a/monitor.c b/monitor.c > >> index e36fb53..e53c6e1 100644 > >> --- a/monitor.c > >> +++ b/monitor.c > >> @@ -4141,9 +4141,6 @@ QemuOptsList qemu_mon_opts = { > >> .name = "chardev", > >> .type = QEMU_OPT_STRING, > >> },{ > >> - .name = "default", /* deprecated */ > >> - .type = QEMU_OPT_BOOL, > >> - },{ > >> .name = "pretty", > >> .type = QEMU_OPT_BOOL, > >> }, > >> diff --git a/qemu-doc.texi b/qemu-doc.texi > >> index d9861b3..6913b32 100644 > >> --- a/qemu-doc.texi > >> +++ b/qemu-doc.texi > >> @@ -2401,15 +2401,6 @@ setting ``-machine kernel_irqchip=off''. > >> The ``-no-kvm'' argument is now a synonym for setting > >> ``-machine accel=tcg''. > >> > >> -@subsection -mon default=on (since 2.4.0) > >> - > >> -The ``default'' option to the ``-mon'' argument is > >> -now ignored. When multiple monitors were enabled, it > >> -indicated which monitor would receive log messages > >> -from the various subsystems. This feature is no longer > >> -required as messages are now only sent to the monitor > >> -in response to explicitly monitor commands. > >> - > >> @subsection -vnc tls (since 2.5.0) > >> > >> The ``-vnc tls'' argument is now a synonym for setting > >> diff --git a/vl.c b/vl.c > >> index 2644400..4e7a7e4 100644 > >> --- a/vl.c > >> +++ b/vl.c > >> @@ -2438,10 +2438,6 @@ static int mon_init_func(void *opaque, QemuOpts *opts, Error **errp) > >> if (qemu_opt_get_bool(opts, "pretty", 0)) > >> flags |= MONITOR_USE_PRETTY; > >> > >> - if (qemu_opt_get_bool(opts, "default", 0)) { > >> - error_report("option 'default' does nothing and is deprecated"); > >> - } > >> - > >> chardev = qemu_opt_get(opts, "chardev"); > >> chr = qemu_chr_find(chardev); > >> if (chr == NULL) { > >> -- > >> 1.8.3.1 > >> > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK