From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1esvJY-0002Zu-4N for mharc-qemu-trivial@gnu.org; Mon, 05 Mar 2018 13:58:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esvJS-0002Ua-LC for qemu-trivial@nongnu.org; Mon, 05 Mar 2018 13:58:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esvJR-0005oT-RE for qemu-trivial@nongnu.org; Mon, 05 Mar 2018 13:58:18 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54064 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1esvJH-0005kP-Uo; Mon, 05 Mar 2018 13:58:08 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3BEA54063640; Mon, 5 Mar 2018 18:58:07 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86AF71C551; Mon, 5 Mar 2018 18:57:56 +0000 (UTC) Date: Mon, 5 Mar 2018 18:57:54 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-trivial@nongnu.org, Peter Maydell , Michael Walle , Mark Cave-Ayland , qemu-devel@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Yongbok Kim , Marek Vasut , Alexander Graf , =?utf-8?B?SGVydsOp?= Poussineau , Marcel Apfelbaum , Samuel Thibault , Richard Henderson , Artyom Tarasenko , Eduardo Habkost , "open list:ARM" , David Gibson , Chris Wulff , Subbaraya Sundeep , Paul Burton , "open list:New World" , Aurelien Jarno Message-ID: <20180305185754.GE17368@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180305112732.26471-1-f4bug@amsat.org> <20180305112732.26471-3-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180305112732.26471-3-f4bug@amsat.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 05 Mar 2018 18:58:07 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 05 Mar 2018 18:58:07 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'berrange@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 18:58:22 -0000 On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daud=C3=A9 wro= te: > These files were including "qemu/cutils.h" to use the byte-based size > definitions, now available in "qemu/cunits.h". I know I'm "complaining" about bike-shed colour here.... Feels like just calling it units.h is sufficient - all our .h code is C code so don't need reminding of it by filename, particularly since we're avoiding system header clash by using the qemu/ prefix on #includes= . > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Regardless of whether you rename it or not though, Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|