From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1etCnx-0006ZT-Le for mharc-qemu-trivial@gnu.org; Tue, 06 Mar 2018 08:38:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCnv-0006Wo-Qx for qemu-trivial@nongnu.org; Tue, 06 Mar 2018 08:38:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCnu-0002RJ-PV for qemu-trivial@nongnu.org; Tue, 06 Mar 2018 08:38:55 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36104 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etCnp-0002Ic-Vf; Tue, 06 Mar 2018 08:38:50 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2CDCE4068021; Tue, 6 Mar 2018 13:38:49 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42DBA10B0F33; Tue, 6 Mar 2018 13:38:44 +0000 (UTC) Date: Tue, 6 Mar 2018 13:38:42 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: QEMU Developers , QEMU Trivial , Stefan Hajnoczi Message-ID: <20180306133842.GH6163@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180306132430.32110-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 06 Mar 2018 13:38:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 06 Mar 2018 13:38:49 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'berrange@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH] misc: don't use hwaddr as a type in trace events X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 13:38:57 -0000 On Tue, Mar 06, 2018 at 01:33:42PM +0000, Peter Maydell wrote: > On 6 March 2018 at 13:24, Daniel P. Berrang=C3=A9 = wrote: > > Use types that are defined by QEMU in trace events caused build failu= res > > for the UST trace backend: > > > > In file included from trace-ust-all.c:13:0: > > trace-ust-all.h:11844:206: error: unknown type name =E2=80=98hwaddr= =E2=80=99 > > > > It only knows about C built-in types, and any types that are pulled i= n > > from includs of qemu-common.h and lttng/tracepoint.h. This does not > > include the 'hwaddr' type, so replace it with a uint64_t which is wha= t > > exec/hwaddr.h defines 'hwaddr' as. This fixes the build failure > > introduced by > > > > commit 9eb8040c2d2b38e1a40bb6129b1b668fa178fcab > > Author: Peter Maydell > > Date: Fri Mar 2 10:45:39 2018 +0000 > > > > hw/misc/tz-ppc: Model TrustZone peripheral protection controller > > > > Signed-off-by: Daniel P. Berrang=C3=A9 > > --- >=20 > Oops. >=20 > > --- a/hw/misc/trace-events > > +++ b/hw/misc/trace-events > > @@ -92,8 +92,8 @@ tz_ppc_cfg_sec_resp(int level) "TZ PPC: cfg_sec_res= p =3D %d" > > tz_ppc_irq_enable(int level) "TZ PPC: int_enable =3D %d" > > tz_ppc_irq_clear(int level) "TZ PPC: int_clear =3D %d" > > tz_ppc_update_irq(int level) "TZ PPC: setting irq line to %d" > > -tz_ppc_read_blocked(int n, hwaddr offset, bool secure, bool user) "T= Z PPC: port %d offset 0x%" HWADDR_PRIx " read (secure %d user %d) blocked= " > > -tz_ppc_write_blocked(int n, hwaddr offset, bool secure, bool user) "= TZ PPC: port %d offset 0x%" HWADDR_PRIx " write (secure %d user %d) block= ed" > > +tz_ppc_read_blocked(int n, uint64_t offset, bool secure, bool user) = "TZ PPC: port %d offset 0x%" HWADDR_PRIx " read (secure %d user %d) block= ed" > > +tz_ppc_write_blocked(int n, uint64_t offset, bool secure, bool user)= "TZ PPC: port %d offset 0x%" HWADDR_PRIx " write (secure %d user %d) blo= cked" >=20 >=20 > If the type isn't "hwaddr" then HWADDR_PRIx is the wrong > format string macro -- those should change to PRIx64. Eeek, that HWADDR_PRIx macro is used throughout this file, sometimes even with uint32_t as the arg ! Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|