* [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
@ 2019-03-11 10:27 Philippe Mathieu-Daudé
2019-03-11 10:32 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-11 10:27 UTC (permalink / raw)
To: qemu-devel, qemu-trivial, Jason Wang
Cc: Helge Deller, Aleksandar Rikalo, Aurelien Jarno,
Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested
(with -d guest_errors):
$ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
Bad SWSTYLE=0x04
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Helge patch "pcnet: Avoid warning when switching back to 16bit mode"
remembered me I had this one somewhere.
---
hw/net/pcnet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index d9ba04bdfc..16683091c9 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -36,6 +36,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "hw/qdev.h"
#include "net/net.h"
#include "net/eth.h"
@@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
val |= 0x0300;
break;
default:
- printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
+ qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
+ val & 0xff);
val = 0x0200;
break;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
2019-03-11 10:27 [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
@ 2019-03-11 10:32 ` Philippe Mathieu-Daudé
2019-03-11 10:36 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2019-04-11 18:14 ` [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-11 10:32 UTC (permalink / raw)
To: qemu-devel, qemu-trivial, Jason Wang
Cc: Helge Deller, Aleksandar Rikalo, Aurelien Jarno
Oops 'fprintf' -> 'printf' in patch subject.
On 3/11/19 11:27 AM, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested
> (with -d guest_errors):
>
> $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
> Bad SWSTYLE=0x04
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Helge patch "pcnet: Avoid warning when switching back to 16bit mode"
> remembered me I had this one somewhere.
> ---
> hw/net/pcnet.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
> index d9ba04bdfc..16683091c9 100644
> --- a/hw/net/pcnet.c
> +++ b/hw/net/pcnet.c
> @@ -36,6 +36,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/qdev.h"
> #include "net/net.h"
> #include "net/eth.h"
> @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
> val |= 0x0300;
> break;
> default:
> - printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
> + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
> + val & 0xff);
> val = 0x0200;
> break;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
2019-03-11 10:27 [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2019-03-11 10:32 ` Philippe Mathieu-Daudé
@ 2019-03-11 10:36 ` Thomas Huth
2019-04-11 18:14 ` [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-03-11 10:36 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial, Jason Wang
Cc: Aleksandar Rikalo, Helge Deller, Aurelien Jarno
On 11/03/2019 11.27, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested
> (with -d guest_errors):
>
> $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
> Bad SWSTYLE=0x04
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Helge patch "pcnet: Avoid warning when switching back to 16bit mode"
> remembered me I had this one somewhere.
> ---
> hw/net/pcnet.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
> index d9ba04bdfc..16683091c9 100644
> --- a/hw/net/pcnet.c
> +++ b/hw/net/pcnet.c
> @@ -36,6 +36,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/qdev.h"
> #include "net/net.h"
> #include "net/eth.h"
> @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
> val |= 0x0300;
> break;
> default:
> - printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
> + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
> + val & 0xff);
> val = 0x0200;
> break;
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
2019-03-11 10:27 [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2019-03-11 10:32 ` Philippe Mathieu-Daudé
2019-03-11 10:36 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
@ 2019-04-11 18:14 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-04-11 18:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial, Jason Wang
Cc: Aleksandar Rikalo, Helge Deller
On 11/03/2019 11:27, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested
> (with -d guest_errors):
>
> $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
> Bad SWSTYLE=0x04
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Helge patch "pcnet: Avoid warning when switching back to 16bit mode"
> remembered me I had this one somewhere.
> ---
> hw/net/pcnet.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
> index d9ba04bdfc..16683091c9 100644
> --- a/hw/net/pcnet.c
> +++ b/hw/net/pcnet.c
> @@ -36,6 +36,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/qdev.h"
> #include "net/net.h"
> #include "net/eth.h"
> @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
> val |= 0x0300;
> break;
> default:
> - printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
> + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
> + val & 0xff);
> val = 0x0200;
> break;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-11 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-11 10:27 [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2019-03-11 10:32 ` Philippe Mathieu-Daudé
2019-03-11 10:36 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2019-04-11 18:14 ` [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).